Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deadfinder 1.3.4 (new formula) #161231

Merged
merged 2 commits into from
Jan 31, 2024
Merged

deadfinder 1.3.4 (new formula) #161231

merged 2 commits into from
Jan 31, 2024

Conversation

p-linnane
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This cannot use system Ruby, so that audit is failing. Removing that audit was discussed previously, so I'm going to look into that as well.

@p-linnane p-linnane added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Jan 29, 2024
@github-actions github-actions bot added new formula PR adds a new formula to Homebrew/homebrew-core ruby Ruby use is a significant feature of the PR or issue labels Jan 29, 2024
@p-linnane p-linnane added the ready to merge PR can be merged once CI is green label Jan 29, 2024
Formula/d/deadfinder.rb Outdated Show resolved Hide resolved
Signed-off-by: Patrick Linnane <patrick@linnane.io>
Copy link
Contributor

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jan 31, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Jan 31, 2024
Merged via the queue into Homebrew:master with commit 0696d9e Jan 31, 2024
12 checks passed
@p-linnane p-linnane deleted the deadfinder-add-formula branch January 31, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. new formula PR adds a new formula to Homebrew/homebrew-core ready to merge PR can be merged once CI is green ruby Ruby use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants