Revert "workflows/autobump: set HOMEBREW_TEST_BOT_AUTOBUMP." #163023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
workflows
p-linnane
approved these changes
Feb 17, 2024
|
Makes sense, thanks @Bo98 for the PR and cleaning up the PRs and sorry for the pain ❤️ |
7 tasks
apainintheneck
added a commit
to Homebrew/brew
that referenced
this pull request
Mar 1, 2024
This simply removes the environment variable check. The code was disabled in core around two weeks ago in Homebrew/homebrew-core#163023. We need this PR to land first as explained in Homebrew/actions#506 (comment) to unblock other PRs.
7 tasks
apainintheneck
added a commit
to Homebrew/brew
that referenced
this pull request
Mar 1, 2024
This simply removes the environment variable check. The code was disabled in core around two weeks ago in Homebrew/homebrew-core#163023. We need this PR to land first as explained in Homebrew/actions#506 (comment) to unblock other PRs.
ZhongRuoyu
added a commit
that referenced
this pull request
Mar 1, 2024
This is needed for Homebrew/brew#16750. Note that #163023 is no longer relevant as the ability to skip duplicate PR check in `brew bump` has been completely removed in Homebrew/brew#16781.
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #162841
#162841 disabled duplicate PR checking, which goes against what autobump is designed to do. Duplicate PRs are supposed to be done by people, not bots, as if it's a duplicate then it likely means simple bumping fails and needs manual edits (and
brew bump-formula-prsupports including manual edits if run locally). Autobump also relies on duplicate PR checking to avoid repeatedly opening the same PR.Fixes various duplicate PRs being opened, which I've gone through and closed.