Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python-platformdirs: remove #163603

Merged
merged 1 commit into from
Feb 21, 2024
Merged

python-platformdirs: remove #163603

merged 1 commit into from
Feb 21, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Feb 21, 2024

Formula added in #155441 on 2023-11-24.

Need revision bump for abi3audit and black prior to merge.

==> Analytics
install: 20,150 (30 days), 56,374 (90 days), 56,379 (365 days)
install-on-request: 397 (30 days), 705 (90 days), 702 (365 days)
build-error: 0 (30 days)
Bottle contents 
❯ tar -ztvf $(brew --cache --quiet python-platformdirs)
drwxr-xr-x  0 0      0           0 Feb  1  2020 python-platformdirs/4.2.0/
drwxr-xr-x  0 0      0           0 Feb  1  2020 python-platformdirs/4.2.0/.brew/
-rw-r--r--  0 0      0        1121 Feb  1  2020 python-platformdirs/4.2.0/.brew/python-platformdirs.rb
-rw-r--r--  0 0      0        1089 Feb  1  2020 python-platformdirs/4.2.0/LICENSE
-rw-r--r--  0 0      0        9340 Feb  1  2020 python-platformdirs/4.2.0/README.rst
drwxr-xr-x  0 0      0           0 Feb  1  2020 python-platformdirs/4.2.0/lib/
drwxr-xr-x  0 0      0           0 Feb  1  2020 python-platformdirs/4.2.0/lib/python3.11/
drwxr-xr-x  0 0      0           0 Feb  1  2020 python-platformdirs/4.2.0/lib/python3.11/site-packages/
drwxr-xr-x  0 0      0           0 Feb  1  2020 python-platformdirs/4.2.0/lib/python3.11/site-packages/platformdirs/
-r--r--r--  0 0      0       22134 Feb  1  2020 python-platformdirs/4.2.0/lib/python3.11/site-packages/platformdirs/__init__.py
-r--r--r--  0 0      0        1489 Feb  1  2020 python-platformdirs/4.2.0/lib/python3.11/site-packages/platformdirs/__main__.py
-r--r--r--  0 0      0        7582 Feb  1  2020 python-platformdirs/4.2.0/lib/python3.11/site-packages/platformdirs/android.py
-r--r--r--  0 0      0        8940 Feb  1  2020 python-platformdirs/4.2.0/lib/python3.11/site-packages/platformdirs/api.py
-r--r--r--  0 0      0        5620 Feb  1  2020 python-platformdirs/4.2.0/lib/python3.11/site-packages/platformdirs/macos.py
-r--r--r--  0 0      0           0 Feb  1  2020 python-platformdirs/4.2.0/lib/python3.11/site-packages/platformdirs/py.typed
-r--r--r--  0 0      0       10591 Feb  1  2020 python-platformdirs/4.2.0/lib/python3.11/site-packages/platformdirs/unix.py
-r--r--r--  0 0      0         411 Feb  1  2020 python-platformdirs/4.2.0/lib/python3.11/site-packages/platformdirs/version.py
-r--r--r--  0 0      0       10008 Feb  1  2020 python-platformdirs/4.2.0/lib/python3.11/site-packages/platformdirs/windows.py
drwxr-xr-x  0 0      0           0 Feb  1  2020 python-platformdirs/4.2.0/lib/python3.11/site-packages/platformdirs-4.2.0.dist-info/
-r--r--r--  0 0      0           4 Feb  1  2020 python-platformdirs/4.2.0/lib/python3.11/site-packages/platformdirs-4.2.0.dist-info/INSTALLER
-r--r--r--  0 0      0       11366 Feb  1  2020 python-platformdirs/4.2.0/lib/python3.11/site-packages/platformdirs-4.2.0.dist-info/METADATA
-r--r--r--  0 0      0        1334 Feb  1  2020 python-platformdirs/4.2.0/lib/python3.11/site-packages/platformdirs-4.2.0.dist-info/RECORD
-r--r--r--  0 0      0           0 Feb  1  2020 python-platformdirs/4.2.0/lib/python3.11/site-packages/platformdirs-4.2.0.dist-info/REQUESTED
-r--r--r--  0 0      0          87 Feb  1  2020 python-platformdirs/4.2.0/lib/python3.11/site-packages/platformdirs-4.2.0.dist-info/WHEEL
-r--r--r--  0 0      0         106 Feb  1  2020 python-platformdirs/4.2.0/lib/python3.11/site-packages/platformdirs-4.2.0.dist-info/direct_url.json
drwxr-xr-x  0 0      0           0 Feb  1  2020 python-platformdirs/4.2.0/lib/python3.11/site-packages/platformdirs-4.2.0.dist-info/licenses/
-r--r--r--  0 0      0        1089 Feb  1  2020 python-platformdirs/4.2.0/lib/python3.11/site-packages/platformdirs-4.2.0.dist-info/licenses/LICENSE
drwxr-xr-x  0 0      0           0 Feb  1  2020 python-platformdirs/4.2.0/lib/python3.12/
drwxr-xr-x  0 0      0           0 Feb  1  2020 python-platformdirs/4.2.0/lib/python3.12/site-packages/
drwxr-xr-x  0 0      0           0 Feb  1  2020 python-platformdirs/4.2.0/lib/python3.12/site-packages/platformdirs/
-r--r--r--  0 0      0       22134 Feb  1  2020 python-platformdirs/4.2.0/lib/python3.12/site-packages/platformdirs/__init__.py
-r--r--r--  0 0      0        1489 Feb  1  2020 python-platformdirs/4.2.0/lib/python3.12/site-packages/platformdirs/__main__.py
-r--r--r--  0 0      0        7582 Feb  1  2020 python-platformdirs/4.2.0/lib/python3.12/site-packages/platformdirs/android.py
-r--r--r--  0 0      0        8940 Feb  1  2020 python-platformdirs/4.2.0/lib/python3.12/site-packages/platformdirs/api.py
-r--r--r--  0 0      0        5620 Feb  1  2020 python-platformdirs/4.2.0/lib/python3.12/site-packages/platformdirs/macos.py
-r--r--r--  0 0      0           0 Feb  1  2020 python-platformdirs/4.2.0/lib/python3.12/site-packages/platformdirs/py.typed
-r--r--r--  0 0      0       10591 Feb  1  2020 python-platformdirs/4.2.0/lib/python3.12/site-packages/platformdirs/unix.py
-r--r--r--  0 0      0         411 Feb  1  2020 python-platformdirs/4.2.0/lib/python3.12/site-packages/platformdirs/version.py
-r--r--r--  0 0      0       10008 Feb  1  2020 python-platformdirs/4.2.0/lib/python3.12/site-packages/platformdirs/windows.py
drwxr-xr-x  0 0      0           0 Feb  1  2020 python-platformdirs/4.2.0/lib/python3.12/site-packages/platformdirs-4.2.0.dist-info/
-r--r--r--  0 0      0           4 Feb  1  2020 python-platformdirs/4.2.0/lib/python3.12/site-packages/platformdirs-4.2.0.dist-info/INSTALLER
-r--r--r--  0 0      0       11366 Feb  1  2020 python-platformdirs/4.2.0/lib/python3.12/site-packages/platformdirs-4.2.0.dist-info/METADATA
-r--r--r--  0 0      0        1334 Feb  1  2020 python-platformdirs/4.2.0/lib/python3.12/site-packages/platformdirs-4.2.0.dist-info/RECORD
-r--r--r--  0 0      0           0 Feb  1  2020 python-platformdirs/4.2.0/lib/python3.12/site-packages/platformdirs-4.2.0.dist-info/REQUESTED
-r--r--r--  0 0      0          87 Feb  1  2020 python-platformdirs/4.2.0/lib/python3.12/site-packages/platformdirs-4.2.0.dist-info/WHEEL
-r--r--r--  0 0      0         106 Feb  1  2020 python-platformdirs/4.2.0/lib/python3.12/site-packages/platformdirs-4.2.0.dist-info/direct_url.json
drwxr-xr-x  0 0      0           0 Feb  1  2020 python-platformdirs/4.2.0/lib/python3.12/site-packages/platformdirs-4.2.0.dist-info/licenses/
-r--r--r--  0 0      0        1089 Feb  1  2020 python-platformdirs/4.2.0/lib/python3.12/site-packages/platformdirs-4.2.0.dist-info/licenses/LICENSE

@cho-m cho-m added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Feb 21, 2024
@github-actions github-actions bot added the marked for removal/rejection PR is probably going to be closed or formula deleted label Feb 21, 2024
@cho-m cho-m mentioned this pull request Feb 21, 2024
Merged
6 tasks
@p-linnane p-linnane marked this pull request as ready for review February 21, 2024 22:53
@p-linnane p-linnane added this pull request to the merge queue Feb 21, 2024
@chenrui333 chenrui333 added the python-vendoring Part of the Python resource vendoring project label Feb 21, 2024
Merged via the queue into Homebrew:master with commit 88078ab Feb 21, 2024
15 checks passed
@scentoni
Copy link

This removal seems to have messed up my brew installation.

# brew doctor
...
Warning: Some installed kegs have no formulae!
This means they were either deleted or installed manually.
You should find replacements for the following formulae:
  python-attrs
  python-platformdirs
...

and

$ brew uninstall python-platformdirs
Error: Refusing to uninstall /usr/local/Cellar/python-platformdirs/4.2.0
because it is required by ansible-lint, which is currently installed.
You can override this and force removal with:
  brew uninstall --ignore-dependencies python-platformdirs

@p-linnane p-linnane mentioned this pull request Feb 23, 2024
Merged
6 tasks
@p-linnane
Copy link
Member

Apologies @scentoni. We missed revision bumping that formula. This will be fixed by #163944.

@p-linnane
Copy link
Member

As a workaround you should be able to run brew reinstall ansible-lint for now.

@cho-m
Copy link
Member Author

cho-m commented Feb 23, 2024 •
edited
Loading

ansible-lint is a bit odd as it doesn't have a direct dependency on those. It had an indirect dependency via black (which was revision bumped in #163605).

This may be related to new brew feature that avoids upgrading some formulae based on tab info. Or could be related to old tab bug - Homebrew/brew#13717

@cho-m cho-m deleted the python-platformdirs-remove branch February 23, 2024 21:03
@dhensen dhensen mentioned this pull request Feb 28, 2024
Closed
4 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 24, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@p-linnane p-linnane p-linnane approved these changes

Assignees
No one assigned
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. marked for removal/rejection PR is probably going to be closed or formula deleted outdated PR was locked due to age python-vendoring Part of the Python resource vendoring project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cho-m @scentoni @p-linnane @chenrui333