Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python-mutagen: remove #164365

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Feb 27, 2024

==> Analytics
install: 2,429 (30 days), 10,893 (90 days), 35,910 (365 days)
install-on-request: 60 (30 days), 178 (90 days), 519 (365 days)
build-error: 0 (30 days)

Need to check on previous dependents:

@cho-m cho-m added the python-vendoring Part of the Python resource vendoring project label Feb 27, 2024
@github-actions github-actions bot added the marked for removal/rejection PR is probably going to be closed or formula deleted label Feb 27, 2024
@cho-m cho-m added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Feb 27, 2024
@p-linnane p-linnane force-pushed the python-mutagen-remove branch from 54abb3c to 98aa33e Compare February 27, 2024 17:38
@p-linnane
Copy link
Member

I took care of yt-dlp last week: #163262

@cho-m
Copy link
Member Author

cho-m commented Mar 1, 2024

I took care of yt-dlp last week: #163262

More of situation on revision bumps. I may need to locally test out removals some more (particularly for users who don't run brew upgrade).

@cho-m cho-m closed this Mar 1, 2024
@cho-m cho-m deleted the python-mutagen-remove branch March 1, 2024 16:16
@cho-m cho-m restored the python-mutagen-remove branch March 1, 2024 16:17
@cho-m cho-m reopened this Mar 1, 2024
@cho-m cho-m marked this pull request as ready for review March 6, 2024 00:39
@BrewTestBot BrewTestBot added this pull request to the merge queue Mar 6, 2024
@cho-m
Copy link
Member Author

cho-m commented Mar 6, 2024

I do think brew should block uninstallations of python-* packages if existing formula tab uses it. So probably okay without revision bumps. Can resolve if users complain later on. Most of time, issues seem like users see the "formula ... is removed" message and think something is broken when they can't uninstall it.

Merged via the queue into Homebrew:master with commit 84a4212 Mar 6, 2024
30 checks passed
@cho-m cho-m deleted the python-mutagen-remove branch March 12, 2024 22:43
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 12, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. marked for removal/rejection PR is probably going to be closed or formula deleted outdated PR was locked due to age python-vendoring Part of the Python resource vendoring project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants