python@3.12: tweak EXTERNALLY-MANAGED guidance #165681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NB: I haven't marked a rebuild or anything else here, not sure if it's worth it. I figure the next patch/bugfix release can send this out as well. |
colindean
reviewed
Mar 10, 2024
github-actions
bot
added
the
autosquash
woodruffw
force-pushed
the
ww/externally-managed-tweaks
branch
from
4422fe5
to
fd8237c
Compare
Bo98
added
CI-skip-dependents
Bo98
reviewed
Mar 10, 2024
Formula/p/python@3.12.rb
Outdated
Comment on lines
410
to
413
| Expert users may restore the old behavior of pip by passing | ||
| the '--break-system-packages' flag to pip, or by adding | ||
| 'break-system-packages = true' to their pip.conf file. The latter | ||
| will permanently disable this warning. |
There was a problem hiding this comment.
Maybe worth mentioning that it's strongly recommended to also pass/set --user to avoid the risk of brew link errors if you happen to install something brew ships.
There was a problem hiding this comment.
Yeah, good catch -- I think this should only mention the --user case, since any other case is likely to break Homebrew + we strongly want to discourage anyways. I'll update today!
There was a problem hiding this comment.
Updated, PTAL! Also fixed the use of second person to be consistent with the rest of the error.
Co-authored-by: Colin Dean <colindean@users.noreply.github.com>
woodruffw
force-pushed
the
ww/externally-managed-tweaks
branch
from
b78fa67
to
6e68ac8
Compare
github-actions
bot
removed
the
autosquash
carlocab
approved these changes
Mar 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?Per https://github.com/orgs/Homebrew/discussions/3404#discussioncomment-8724311: this tweaks the
EXTERNALLY-MANAGEDmarker on Python 3.12:--break-system-packagesescape hatch as something expert users can doWording feedback greatly appreciated 🙂