Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protoc-gen-js 3.21.2 (new formula) #165868

Merged
merged 1 commit into from
Mar 24, 2024
Merged

protoc-gen-js 3.21.2 (new formula) #165868

merged 1 commit into from
Mar 24, 2024

Conversation

luangong
Copy link
Contributor

@luangong luangong commented Mar 12, 2024 •
edited
Loading

Related: #113481

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren’t other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you’re submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you’re submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the new formula PR adds a new formula to Homebrew/homebrew-core label Mar 12, 2024
@luangong luangong mentioned this pull request Mar 12, 2024
Closed
@luangong luangong marked this pull request as draft March 12, 2024 15:55
@luangong luangong marked this pull request as ready for review March 12, 2024 16:34
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request long build Set a long timeout for formula testing and removed automerge-skip `brew pr-automerge` will skip this pull request labels Mar 13, 2024
@luangong
Copy link
Contributor Author

luangong commented Mar 14, 2024 •
edited
Loading

@fxcoudert, @chenrui333, @carlocab, @dtrodrigues

Hi! Can someone please help me with the labels? Thanks!

@luangong luangong marked this pull request as draft March 18, 2024 13:12
@luangong luangong marked this pull request as ready for review March 18, 2024 13:17
@fxcoudert fxcoudert added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Mar 20, 2024
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Mar 20, 2024
@luangong luangong requested a review from fxcoudert March 21, 2024 11:50
@SMillerDev SMillerDev added this pull request to the merge queue Mar 24, 2024
Merged via the queue into Homebrew:master with commit 666d8b4 Mar 24, 2024
25 checks passed
@luangong luangong deleted the protoc-gen-js branch March 30, 2024 18:05
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 29, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fxcoudert fxcoudert fxcoudert approved these changes

Assignees
No one assigned
Labels
long build Set a long timeout for formula testing new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luangong @fxcoudert @SMillerDev