Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protobuf 26.1 #166008

Merged
merged 44 commits into from
Apr 2, 2024
Merged

protobuf 26.1 #166008

merged 44 commits into from
Apr 2, 2024

Conversation

chenrui333
Copy link
Member

Created by brew bump


Created with brew bump-formula-pr.

This comment was marked as resolved.

@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request bump-formula-pr PR was created using `brew bump-formula-pr` labels Mar 13, 2024
@carlocab carlocab force-pushed the bump-protobuf-26.0 branch from 78b08ce to 273578d Compare March 14, 2024 06:58
@scpeters
Copy link
Member

I saw the following comment in #166096

Using Python bindings with C++ backend is deprecated and we are removing them from formula in #166008. Officially need to use PyPI source to build with UPB backend (or Bazel in git source but usually better to avoid Bazel).

Is this a change for protobuf only, or is this a policy change for all homebrew formulae (deprecation of python bindings with c++ backend)? If it's a broader change and there's a tracking issue, apologies that I've missed it, and I would appreciate if you could share a link to it.

If this is only for protobuf, then carry on!

@chenrui333
Copy link
Member Author

@scpeters only for protobuf at the moment

@chenrui333 chenrui333 added the in progress Stale bot should stay away label Mar 16, 2024
@cho-m
Copy link
Member

cho-m commented Mar 18, 2024

Is this a change for protobuf only, or is this a policy change for all homebrew formulae (deprecation of python bindings with c++ backend)?

only for protobuf at the moment

Specifically, we are following upstream instructions. If upstream supports Python bindings with C++ backend, we will keep them.

Protobuf doesn't want users/downstreams to build this anymore - protocolbuffers/protobuf@5722aef

@scpeters
Copy link
Member

Is this a change for protobuf only, or is this a policy change for all homebrew formulae (deprecation of python bindings with c++ backend)?

only for protobuf at the moment

Specifically, we are following upstream instructions. If upstream supports Python bindings with C++ backend, we will keep them.

Protobuf doesn't want users/downstreams to build this anymore - protocolbuffers/protobuf@5722aef

thanks for the info!

@cho-m cho-m force-pushed the bump-protobuf-26.0 branch from 605f574 to 7be16df Compare March 23, 2024 17:02
@github-actions github-actions bot added the long build Set a long timeout for formula testing label Mar 23, 2024
@cho-m cho-m added the CI-linux-self-hosted Build on Linux self-hosted runner label Mar 23, 2024
@cho-m cho-m force-pushed the bump-protobuf-26.0 branch from 7be16df to 437a276 Compare March 24, 2024 04:42
@cho-m cho-m added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Mar 24, 2024
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Mar 24, 2024
@scpeters
Copy link
Member

glancing at the grpc failure, it looks like it is caused by an API change in protobuf and needs grpc/grpc#35898

@cho-m cho-m force-pushed the bump-protobuf-26.0 branch from 437a276 to 0e130b0 Compare March 25, 2024 20:08
@chenrui333 chenrui333 added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Mar 27, 2024
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Mar 28, 2024
@cho-m
Copy link
Member

cho-m commented Mar 28, 2024

Need to figure out how to deal with or-tools. It is only compatible with Protobuf 25. I did try building bundled copy but that links conflicting libs into HOMEBREW_PREFIX. Given that it is only a single formula, I may just resource Protobuf 25 into libexec but will need to figure out how to fix up CMake files to pick correct copy.

Other failures are:

  • bear - rizsotto/Bear@4d9d452
  • mavsdk - need to regenerate files with newer protoc
  • nanopb - will need a virtualenv for protobuf python libs
  • sysdig - revision bump

EDIT: There is also a new minor version but I'm not sure if that will invalidate our bottle cache. So may just want to stick to current protobuf version

@cho-m cho-m added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Mar 28, 2024
@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Apr 2, 2024
@BrewTestBot BrewTestBot enabled auto-merge April 2, 2024 12:16
@BrewTestBot BrewTestBot added this pull request to the merge queue Apr 2, 2024
Merged via the queue into master with commit 47e2901 Apr 2, 2024
14 checks passed
@BrewTestBot BrewTestBot deleted the bump-protobuf-26.0 branch April 2, 2024 12:23
@github-actions github-actions bot added the outdated PR was locked due to age label Jul 10, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge-skip `brew pr-automerge` will skip this pull request bump-formula-pr PR was created using `brew bump-formula-pr` CI-linux-self-hosted Build on Linux self-hosted runner CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. long build Set a long timeout for formula testing no long build conflict Do not allow merging other pull requests when files conflict with this one outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants