Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python-requests: deprecate #166056

Merged
merged 4 commits into from
Mar 14, 2024
Merged

python-requests: deprecate #166056

merged 4 commits into from
Mar 14, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Mar 14, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Number of installs are a bit too high to remove directly. Need to wean off usage via deprecation period.

install-on-request: 1,763 (30 days), 2,450 (90 days), 2,727 (365 days)

@cho-m cho-m added the CI-no-bottles Merge without publishing bottles label Mar 14, 2024
@github-actions github-actions bot added the formula deprecated Formula deprecated label Mar 14, 2024
cho-m added 4 commits March 14, 2024 08:31
Signed-off-by: Michael Cho <michael@michaelcho.dev>
Signed-off-by: Michael Cho <michael@michaelcho.dev>
Signed-off-by: Michael Cho <michael@michaelcho.dev>
Signed-off-by: Michael Cho <michael@michaelcho.dev>
@cho-m cho-m force-pushed the python-requests-deprecation branch from ff72ecf to a8b890c Compare March 14, 2024 12:33
@BrewTestBot BrewTestBot added this pull request to the merge queue Mar 14, 2024
Merged via the queue into master with commit baa1841 Mar 14, 2024
21 checks passed
@BrewTestBot BrewTestBot deleted the python-requests-deprecation branch March 14, 2024 22:08
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 14, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2024
@chenrui333 chenrui333 added the python-vendoring Part of the Python resource vendoring project label Nov 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-no-bottles Merge without publishing bottles formula deprecated Formula deprecated outdated PR was locked due to age python-vendoring Part of the Python resource vendoring project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants