Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moon 1.23.0 #167170

Merged
merged 2 commits into from
Mar 27, 2024
Merged

moon 1.23.0 #167170

merged 2 commits into from
Mar 27, 2024

Conversation

BrewTestBot
Copy link
Member

Created by brew bump


Created with brew bump-formula-pr.

release notes
#### 🚀 Updates
  • Added git: and npm: locators to the generator.templates setting in .moon/workspace.yml.
    • This allows templates to be packaged and managed outside of the workspace.
    • Locations will be cloned/downloaded on-demand.
  • Added an id setting to template.yml, so that templates can customize their name (instead of
    using the folder name).
  • Added a variables() function for templates that returns an object of all variables available.
  • Added new functionality for template variables in template.yml:
    • New order setting to control the order in which they are prompted for.
    • New internal setting that ignores values passed on the command line.
    • Updated enum default settings to support an array of values.
  • Added an internal task option, which marks tasks as internal only.
  • Updated task inheritance to support stack-based configuration, such as
    .moon/tasks/node-frontend.yml or .moon/tasks/bun-backend-application.yml.
  • Updated moon project and moon task to include the configuration files that tasks inherit from.
  • Updated moon task to include the modes it belongs to.

🐞 Fixes

  • Fixed an issue where a project's platform was being detected as node (when not enabled), and
    should have been bun. If you're using both bun and node in the same workspace, moon has a
    hard time detecting which should be used for what project. If you run into issues, explicitly set
    the platform in the project's moon.yml.
  • Fixed an issue where template files couldn't import/include/extends files from extended templates.
  • Fixed template enum variable default values being able to use a non-supported value.

⚙️ Internal

  • Configuration JSON schemas are now included within each GitHub release.
  • Updated proto to v0.32.1 (from v0.31.4).
  • Updated Rust to v1.77.

@github-actions github-actions bot added rust Rust use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` labels Mar 26, 2024
@chenrui333
Copy link
Member

  error[E0733]: recursion in an `async fn` requires boxing
     --> nextgen/project-graph/src/project_graph_builder.rs:220:5
      |
  220 | /     async fn internal_load(
  221 | |         &mut self,
  222 | |         project_locator: &str,
  223 | |         cycle: &mut FxHashSet<Id>,
  224 | |     ) -> miette::Result<(Id, NodeIndex)> {
      | |________________________________________^ recursive `async fn`
      |
      = note: a recursive `async fn` must be rewritten to return a boxed `dyn Future`
      = note: consider using the `async_recursion` crate: https://crates.io/crates/async_recursion
  
  For more information about this error, try `rustc --explain E0733`.
  error: could not compile `moon_project_graph` (lib) due to 1 previous error

@chenrui333 chenrui333 added the build failure CI fails while building the software label Mar 26, 2024
@chenrui333
Copy link
Member

@chenrui333
Copy link
Member

will retry this pr after rust 1.77.0, #166865

@chenrui333 chenrui333 added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. ready to merge PR can be merged once CI is green and removed build failure CI fails while building the software CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Mar 27, 2024
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Mar 27, 2024
@BrewTestBot BrewTestBot enabled auto-merge March 27, 2024 16:13
@BrewTestBot BrewTestBot added this pull request to the merge queue Mar 27, 2024
Merged via the queue into master with commit ff398fc Mar 27, 2024
14 checks passed
@BrewTestBot BrewTestBot deleted the bump-moon-1.23.0 branch March 27, 2024 16:21
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 27, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. outdated PR was locked due to age ready to merge PR can be merged once CI is green rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants