Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python@3.12: further tweak EXTERNALLY-MANAGED guidance #167676

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

mikebeaton
Copy link
Contributor

@mikebeaton mikebeaton commented Apr 1, 2024

This updates the very welcome additions in 6e68ac8, but incorporates two further changes:

  • I believe there is an error in the previous source env/bin/activate, which should read source path/to/venv/bin/activate, given the context
  • The previous guidance (prior to 6e68ac8) mentioned python3 instead of python. AFAICT this is more likely to work (e.g. if Python 2 is also installed) and using python in these instructions might perhaps cause additional unnecessary confusion in this case, so this proposes using python3 again

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the CI-linux-self-hosted Build on Linux self-hosted runner label Apr 1, 2024
Copy link
Contributor

github-actions bot commented Apr 1, 2024

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@cho-m cho-m added CI-skip-dependents Pass --skip-dependents to brew test-bot. CI-no-bottles Merge without publishing bottles labels Apr 1, 2024
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes make sense to me, thank you @mikebeaton!

FWIW there is no more default python for Python 2 on macOS anymore, although Homebrew also doesn't do the python3 -> python alias by default. So this change makes sense, but I want to qualify the right reason for it 🙂

@MikeMcQuaid MikeMcQuaid added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Apr 1, 2024
@MikeMcQuaid
Copy link
Member

Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @mikebeaton!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Apr 1, 2024
Merged via the queue into Homebrew:master with commit f7acdb2 Apr 1, 2024
24 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-linux-self-hosted Build on Linux self-hosted runner CI-no-bottles Merge without publishing bottles CI-skip-dependents Pass --skip-dependents to brew test-bot. CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants