Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dolphie 5.0.0 #170229

Merged
merged 2 commits into from
Apr 29, 2024
Merged

dolphie 5.0.0 #170229

merged 2 commits into from
Apr 29, 2024

Conversation

chenrui333
Copy link
Member

@chenrui333 chenrui333 commented Apr 27, 2024 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request autobump labels Apr 27, 2024
@github-actions github-actions bot added python Python use is a significant feature of the PR or issue and removed automerge-skip `brew pr-automerge` will skip this pull request autobump labels Apr 27, 2024
@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Apr 28, 2024
@chenrui333 chenrui333 force-pushed the dolphie-5.0.0 branch 2 times, most recently from 934d1f5 to b1fa12a Compare April 29, 2024 02:54
@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Apr 29, 2024
p-linnane
p-linnane reviewed Apr 29, 2024
View reviewed changes
Formula/d/dolphie.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Apr 29, 2024
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Apr 29, 2024
branchvincent
branchvincent reviewed Apr 29, 2024
View reviewed changes
Formula/d/dolphie.rb Outdated Show resolved Hide resolved
@chenrui333 @p-linnane
dolphie 5.0.0
5ced355 
Signed-off-by: Rui Chen <rui@chenrui.dev>

dolphie: improve syntax

Co-authored-by: Patrick Linnane <patrick@linnane.io>
@github-actions GitHub Actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Apr 29, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Apr 29, 2024
Merged via the queue into master with commit e6b337a Apr 29, 2024
14 checks passed
@BrewTestBot BrewTestBot deleted the dolphie-5.0.0 branch April 29, 2024 04:46
@github-actions github-actions bot added the outdated PR was locked due to age label Jul 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@branchvincent branchvincent branchvincent approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

@p-linnane p-linnane Awaiting requested review from p-linnane

Assignees
No one assigned
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. outdated PR was locked due to age python Python use is a significant feature of the PR or issue ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chenrui333 @branchvincent @p-linnane @BrewTestBot