Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ronn-ng 0.10.1 (new formula) #172077

Merged
merged 2 commits into from
May 19, 2024
Merged

ronn-ng 0.10.1 (new formula) #172077

merged 2 commits into from
May 19, 2024

Conversation

leoheitmannruiz
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

ronn hasn't seen a commit in more than a decade. Debian and Alpine among others have dropped ronn and provide ronn-ng instead.

What do you think about deprecating ronn and pointing to ronn-ng (given that this build recipe looks good)?

@github-actions github-actions bot added new formula PR adds a new formula to Homebrew/homebrew-core ruby Ruby use is a significant feature of the PR or issue labels May 18, 2024
@chenrui333
Copy link
Member

What do you think about deprecating ronn and pointing to ronn-ng (given that this build recipe looks good)?

make sense.

Formula/r/ronn-ng.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label May 18, 2024
@chenrui333
Copy link
Member

Can you squash the commits and add ronn-ng into autobump.txt file? Thanks!

@leoheitmannruiz
Copy link
Contributor Author

I don't know how to do this, sorry. If you can technically do so, I'd really appreciate if you did. Thanks!

@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request autobump and removed autosquash Automatically squash pull request commits according to Homebrew style. labels May 19, 2024
autobump: add ronn-ng

Co-authored-by: Rui Chen <rui@chenrui.dev>
@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label May 19, 2024
@chenrui333
Copy link
Member

  ronn-ng
    * Dependency 'ruby' is provided by macOS; please replace 'depends_on' with 'uses_from_macos'.

@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label May 19, 2024
Copy link
Contributor

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label May 19, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue May 19, 2024
Merged via the queue into Homebrew:master with commit aa17e8a May 19, 2024
14 checks passed
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 18, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2024
@MikeMcQuaid
Copy link
Member

What do you think about deprecating ronn and pointing to ronn-ng (given that this build recipe looks good)?

make sense.

@chenrui333 Please don't deprecate ronn unless it's actually broken for all use-cases for everyone or it has known, unpatched security vulnerabilities.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autobump automerge-skip `brew pr-automerge` will skip this pull request CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age ready to merge PR can be merged once CI is green ruby Ruby use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants