Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mailcatcher: fix missing assets #174319

Closed
wants to merge 1 commit into from

Conversation

sj26
Copy link
Contributor

@sj26 sj26 commented Jun 12, 2024

Without this step the user interface does not function because the javascript and stylesheets are not compiled or included, so cannot be served to browsers.

This command was run in the formula for v0.9.0 but was removed in the update to v0.10.0 (#173471):

104b175#diff-aff4c5be3f339d85e769e3c2362bb626acfde080d57d0bb75f42551ecc3d0413L161

Closes sj26/mailcatcher#560.


  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Without this step the user interface does not function because the
javascript and stylesheets are not compiled or included, so cannot be
served to browsers.

See sj26/mailcatcher#560
@github-actions github-actions bot added nodejs Node or npm use is a significant feature of the PR or issue ruby Ruby use is a significant feature of the PR or issue labels Jun 12, 2024
@sj26
Copy link
Contributor Author

sj26 commented Jun 12, 2024

This isn't going to work as-is because the compile-dependencies aren't installed.

It looks like swiftgen installs bundler for use at build time:

# Install bundler (needed for our rake tasks)
ENV["GEM_HOME"] = buildpath/"gem_home"
# we use the macOS ruby (2.6.10p210 (2022-04-12 revision 67958)) this is the last supported bundler version
system "gem", "install", "bundler", "-v 2.4.22"
ENV.prepend_path "PATH", buildpath/"gem_home/bin"
system "bundle", "install", "--without", "development", "release"
# Disable linting
ENV["NO_CODE_LINT"] = "1"
# Install SwiftGen in `libexec` (because of our resource bundle)
# Then create a script to invoke it
system "bundle", "exec", "rake", "cli:install[#{libexec}]"

Maybe this should do the same.

Copy link
Contributor

github-actions bot commented Jul 3, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Jul 3, 2024
@github-actions github-actions bot closed this Jul 10, 2024
@idapartners
Copy link

This seems to have been closed due to lack of activity, but ... it's still an issue. How do we re-open it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nodejs Node or npm use is a significant feature of the PR or issue ruby Ruby use is a significant feature of the PR or issue stale No recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MailCatcher UI not working in 0.10.0 (when installed via homebrew)
2 participants