Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solo2-cli: add rust 1.79.0 build patch #174784

Merged
merged 1 commit into from
Jun 26, 2024
Merged

solo2-cli: add rust 1.79.0 build patch #174784

merged 1 commit into from
Jun 26, 2024

Conversation

chenrui333
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

followup #174480
solokeys/solo2-cli#122

@github-actions github-actions bot added the rust Rust use is a significant feature of the PR or issue label Jun 17, 2024
@chenrui333 chenrui333 added CI-no-bottles Merge without publishing bottles CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Jun 17, 2024
@chenrui333
Copy link
Member Author

only test failure on 13-arm

  ==> /opt/homebrew/Cellar/solo2-cli/0.2.2/bin/solo2 ls
  
  Error: solo2-cli: failed
  Error: solo2-cli: failed
  An exception occurred within a child process:
    Minitest::Assertion: Expected: 0
    Actual: nil

@chenrui333 chenrui333 added the 13-arm64 Ventura arm64 is specifically affected label Jun 18, 2024
Signed-off-by: Rui Chen <rui@chenrui.dev>
@BrewTestBot BrewTestBot added this pull request to the merge queue Jun 26, 2024
Merged via the queue into master with commit fada7fa Jun 26, 2024
25 checks passed
@BrewTestBot BrewTestBot deleted the solo2-cli-rust-fix branch June 26, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
13-arm64 Ventura arm64 is specifically affected CI-no-bottles Merge without publishing bottles CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants