Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

watchman: use default state directory (TMPDIR). #179380

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Conversation

MikeMcQuaid
Copy link
Member

Take 2 on #173850. Sadly #174554 was not sufficient to resolve the issues here. I've seen it personally and with several other users in person.

Doing this:

  • avoids the need for post_install
  • avoids permissions errors when running watchman as a user that didn't install it via Homebrew:
2024-06-03T13:36:47,061: [] the owner of /opt/homebrew/var/run/watchman/mike-state is uid 502 and doesn't match your euid 501

@github-actions github-actions bot added python Python use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue boost Boost use is a significant feature of the PR or issue labels Aug 2, 2024
Doing this:
- avoids the need for ` post_install`
- avoids permissions errors when running `watchman` as a user that
  didn't install it via Homebrew:
```
2024-06-03T13:36:47,061: [] the owner of /opt/homebrew/var/run/watchman/mike-state is uid 502 and doesn't match your euid 501
```
@MikeMcQuaid MikeMcQuaid requested a review from a team August 2, 2024 11:57
Copy link
Contributor

github-actions bot commented Aug 2, 2024

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Aug 2, 2024
@BrewTestBot BrewTestBot enabled auto-merge August 2, 2024 12:09
@BrewTestBot BrewTestBot added this pull request to the merge queue Aug 2, 2024
Merged via the queue into master with commit 32f3a49 Aug 2, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the watchman-tmp branch August 2, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
boost Boost use is a significant feature of the PR or issue CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. python Python use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants