Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pcl: revision bump (lz4 1.10.0) #181633

Closed
wants to merge 1 commit into from
Closed

pcl: revision bump (lz4 1.10.0) #181633

wants to merge 1 commit into from

Conversation

carlocab
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Spotted in #178056 and #181564.

It's likely that this or one of its dependencies hard-codes a reference
to lz4's Cellar path. Ideally that should be fixed.

Spotted in #178056 and #181564.

It's likely that this or one of its dependencies hard-codes a reference
to `lz4`'s Cellar path. Ideally that should be fixed.
@github-actions github-actions bot added long build Set a long timeout for formula testing boost Boost use is a significant feature of the PR or issue labels Aug 19, 2024
@cho-m
Copy link
Member

cho-m commented Aug 19, 2024

Should be from flann which uses LZ4_LINK_LIBRARIES obtained from FindPkgConfig so paths are saved in generated CMake files.


Though given how often we work around this, should really be handled in brew since it is a side-effect Cellar directory structure.

@carlocab
Copy link
Member Author

Should be from flann which uses LZ4_LINK_LIBRARIES obtained from FindPkgConfig so paths are saved in generated CMake files.

#181636

Though given how often we work around this, should really be handled in brew since it is a side-effect Cellar directory structure.

Agreed. We should open an issue about this, at least.

@carlocab carlocab closed this Aug 19, 2024
@carlocab carlocab deleted the pcl-lz4-1.10.0 branch August 19, 2024 05:16
@cho-m
Copy link
Member

cho-m commented Sep 2, 2024

Though given how often we work around this, should really be handled in brew since it is a side-effect Cellar directory structure.

Agreed. We should open an issue about this, at least.

POC PR in Homebrew/brew#18229

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
boost Boost use is a significant feature of the PR or issue long build Set a long timeout for formula testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants