Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass: update digest #181795

Merged
merged 2 commits into from
Aug 20, 2024
Merged

pass: update digest #181795

merged 2 commits into from
Aug 20, 2024

Conversation

woodruffw
Copy link
Member

@woodruffw woodruffw commented Aug 20, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This updates pass's digest to the latest version served by its upstream. After triage, we've concluded that this digest change was likely caused by a git archive change. No underlying file contents were changed.

@Bo98 independently confirmed that he observed the same digest from the upstream, and confirmed that only the XZ header differs. I'm also copying my pkgdiff results below:

reading packages ...
comparing packages ...
creating report ...
result: UNCHANGED
report: pkgdiff_reports/password-store/1.7.4_to_1.7.4/changes_report.html

_Users_william_pkgdiff_reports_password-store_1 7 4_to_1 7 4_changes_report html

Signed-off-by: William Woodruff <william@yossarian.net>
@woodruffw woodruffw requested a review from Bo98 August 20, 2024 15:45
@woodruffw woodruffw self-assigned this Aug 20, 2024
@woodruffw
Copy link
Member Author

For posterity, here's a copy of both archives + the pkgdiff analysis as well.

Archive.zip

@chenrui333 chenrui333 added upstream issue An upstream issue report is needed checksum mismatch SHA-256 doesn't match the download CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Aug 20, 2024
@chenrui333
Copy link
Member

we also need to notify upstream about the issue as well

@woodruffw
Copy link
Member Author

we also need to notify upstream about the issue as well

Done -- I've sent the maintainer a DM in a shared channel.

@woodruffw woodruffw added the CI-checksum-change-confirmed A checksum change was confirmed by upstream label Aug 20, 2024
Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the diligence here!

Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Aug 20, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Aug 20, 2024
Merged via the queue into master with commit e2e7baa Aug 20, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the ww/update-pass-digest branch August 20, 2024 17:09
@zx2c4
Copy link
Contributor

zx2c4 commented Aug 26, 2024

https://lists.zx2c4.com/pipermail/wireguard/2024-August/008466.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
checksum mismatch SHA-256 doesn't match the download CI-checksum-change-confirmed A checksum change was confirmed by upstream CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. upstream issue An upstream issue report is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants