Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boost: drop single threaded variant #182995

Closed
wants to merge 10 commits into from
Closed

boost: drop single threaded variant #182995

wants to merge 10 commits into from

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Aug 30, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Fedora dropped single-threaded due to no physical difference1.
Arch Linux2 and Debian3 dropped it even longer ago.

Footnotes

  1. https://src.fedoraproject.org/rpms/boost/blob/rawhide/f/boost.spec#_2092

  2. https://gitlab.archlinux.org/archlinux/packaging/packages/boost/-/commit/51d8bb08349d37309a9073bdf034516248012233

  3. https://salsa.debian.org/debian/boost/-/commit/226b0ced201790ec322b3109af1e1a3fa75917f3

@github-actions github-actions bot added the long dependent tests Set a long timeout for dependent testing label Aug 30, 2024
@cho-m cho-m mentioned this pull request Aug 30, 2024
6 tasks
@cho-m
Copy link
Member Author

cho-m commented Aug 30, 2024

Some dependents are probably linked to -mt variant that needs to be rebuilt.

@cho-m cho-m added the CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. label Aug 30, 2024
@cho-m cho-m added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Aug 31, 2024
@github-actions github-actions bot added the long build Set a long timeout for formula testing label Aug 31, 2024
@cho-m cho-m mentioned this pull request Aug 31, 2024
6 tasks
@cho-m cho-m added the in progress Stale bot should stay away label Sep 1, 2024
@cho-m cho-m changed the title boost: drop single threaded variant, backport Boost.Compute fix boost: drop single threaded variant Sep 4, 2024
@cho-m
Copy link
Member Author

cho-m commented Sep 21, 2024

Will defer to 1.87.0 since this requires rebuilding most linked dependents

@cho-m cho-m closed this Sep 21, 2024
@cho-m cho-m deleted the boost-no-single branch September 21, 2024 17:10
@cho-m cho-m added the not merged PR was closed without being merged (and may need to be revisited) label Sep 21, 2024
@carlocab
Copy link
Member

If you want to do this without rebuilding all the dependents, we can maybe add symlinks that from the libraries that are installed to the names that dependents want to find them at (e.g. libboost_system.dylib => libboost_system-mt.dylib).

We can then drop the symlinks in Boost 1.87.

@carlocab carlocab mentioned this pull request Sep 21, 2024
6 tasks
@cho-m cho-m mentioned this pull request Nov 18, 2024
7 tasks
@cho-m cho-m added the superseded PR was replaced by another PR label Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. in progress Stale bot should stay away long build Set a long timeout for formula testing long dependent tests Set a long timeout for dependent testing not merged PR was closed without being merged (and may need to be revisited) superseded PR was replaced by another PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants