Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "autobump: remove kiota" #183727

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

baywet
Copy link

@baywet baywet commented Sep 6, 2024

restores kiota auto-bump, depends on microsoft/kiota#5356 to be merged and released

@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request autobump labels Sep 6, 2024
@chenrui333
Copy link
Member

@baywet thanks for the pr, can you bump kiota to the latest release as well? Thanks!

@baywet
Copy link
Author

baywet commented Sep 6, 2024

@chenrui333 I was wondering whether you would want that to be in the same or a separate PR.
Regardless, we'll need to wait for a new release on kiota's side to unblock things.
Next minor is planned October 5th, but we might have to release a patch version much sooner than that due to other objectives.
Regardless, I'll stand up an update for the formula when that happens.

@chenrui333
Copy link
Member

chenrui333 commented Sep 6, 2024

you can do in the same PR, that is fine. (also squash the commits)

@stefanb
Copy link
Member

stefanb commented Sep 7, 2024

Unmerged upstream PR could be also used to patch official releases until that upstream PR is released.

@baywet
Copy link
Author

baywet commented Sep 7, 2024

How?

This was referenced Sep 8, 2024
@stefanb
Copy link
Member

stefanb commented Sep 8, 2024

Tried with patching in #183911, but it still gives (the same?) error...

@baywet
Copy link
Author

baywet commented Sep 9, 2024

Tried with patching in #183911, but it still gives (the same?) error...

@stefanb That's because even though microsoft/kiota#5356 has been merged, it hasn't been released yet. So unless we can define the Formula to use a commit hash instead of a tag, we'll have to wait before we can create a new version here.

That's why I submitted this PR as draft initially.

@chenrui333
Copy link
Member

i guess we can close it for now, and file a new one once the patch is being released. what do you think @baywet.

@baywet
Copy link
Author

baywet commented Sep 10, 2024

Can we keep it until the patch is out? Supposed to go out on Friday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autobump automerge-skip `brew pr-automerge` will skip this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants