Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solidity: use modern cmake syntax #183889

Merged
merged 2 commits into from
Sep 8, 2024
Merged

solidity: use modern cmake syntax #183889

merged 2 commits into from
Sep 8, 2024

Conversation

chenrui333
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@chenrui333 chenrui333 added the CI-no-bottles Merge without publishing bottles label Sep 7, 2024
@github-actions github-actions bot added the boost Boost use is a significant feature of the PR or issue label Sep 7, 2024
@Homebrew Homebrew deleted a comment from github-actions bot Sep 7, 2024
@chenrui333 chenrui333 mentioned this pull request Sep 7, 2024
Closed
@chenrui333 chenrui333 removed the CI-no-bottles Merge without publishing bottles label Sep 7, 2024
carlocab
carlocab approved these changes Sep 8, 2024
View reviewed changes
Formula/s/solidity.rb Show resolved Hide resolved
@chenrui333 chenrui333 mentioned this pull request Sep 8, 2024
Open
@chenrui333
solidity: use modern cmake syntax
736db1d 
Signed-off-by: Rui Chen <rui@chenrui.dev>

solidity: update to use system fmt, nlohmann-json, and range-v3

Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Sep 8, 2024
carlocab
carlocab approved these changes Sep 8, 2024
View reviewed changes
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Surprised to not see linkage to fmt.

@chenrui333
Copy link
Member Author

Thanks! Surprised to not see linkage to fmt.

yeah, there is no linkage for it

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 8, 2024

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Sep 8, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 8, 2024
Merged via the queue into master with commit 8716bb5 Sep 8, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the solidity-cmake branch September 8, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlocab carlocab carlocab approved these changes

@github-actions GitHub Actions github-actions approved these changes

Assignees
No one assigned
Labels
boost Boost use is a significant feature of the PR or issue CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chenrui333 @carlocab @BrewTestBot