Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pegtl: use modern cmake syntax and update license #183897

Merged
merged 1 commit into from
Sep 10, 2024
Merged

pegtl: use modern cmake syntax and update license #183897

merged 1 commit into from
Sep 10, 2024

Conversation

chenrui333
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@chenrui333 chenrui333 added the CI-no-bottles Merge without publishing bottles label Sep 7, 2024
@Homebrew Homebrew deleted a comment from github-actions bot Sep 7, 2024
@chenrui333 chenrui333 requested review from MikeMcQuaid and a team as code owners September 7, 2024 21:55
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Sep 7, 2024
@chenrui333 chenrui333 changed the title pegtl: use modern cmake syntax pegtl: use modern cmake syntax and update license Sep 7, 2024
@chenrui333 chenrui333 added the license License PRs label Sep 7, 2024
@chenrui333
Copy link
Member Author

@carlocab carlocab removed the automerge-skip `brew pr-automerge` will skip this pull request label Sep 8, 2024
cho-m
cho-m reviewed Sep 9, 2024
View reviewed changes
Formula/p/pegtl.rb Outdated Show resolved Hide resolved
MikeMcQuaid
MikeMcQuaid reviewed Sep 9, 2024
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with @cho-m

@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Sep 10, 2024
@chenrui333 @cho-m
pegtl: use modern cmake syntax
8cf3202 
Signed-off-by: Rui Chen <rui@chenrui.dev>

Co-authored-by: Michael Cho <michael@michaelcho.dev>
@github-actions github-actions bot removed the automerge-skip `brew pr-automerge` will skip this pull request label Sep 10, 2024
@chenrui333
Copy link
Member Author

addressed the pr feedback.

@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 10, 2024
Merged via the queue into master with commit bf8c7e3 Sep 10, 2024
23 checks passed
@BrewTestBot BrewTestBot deleted the pegtl-cmake branch September 10, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid left review comments

@cho-m cho-m cho-m left review comments

@branchvincent branchvincent branchvincent approved these changes

@carlocab carlocab carlocab approved these changes

Assignees
No one assigned
Labels
CI-no-bottles Merge without publishing bottles license License PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chenrui333 @MikeMcQuaid @branchvincent @cho-m @carlocab @BrewTestBot