Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terrascan 1.19.9 #191069

Merged
merged 2 commits into from
Sep 18, 2024
Merged

terrascan 1.19.9 #191069

merged 2 commits into from
Sep 18, 2024

Conversation

BrewTestBot
Copy link
Member

Created by brew bump


Created with brew bump-formula-pr.

release notes
## Changelog
* bd6d393de9800a8777029e3920d6e432a11fcfcd [Fix/1702]Fix protobuf errors in binary built in docker build (#1706)

@github-actions github-actions bot added go Go use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` labels Sep 18, 2024
@stefanb
Copy link
Member

stefanb commented Sep 18, 2024

The problem from previous PRs:

...was fixed here by applying the same ldflags as in upstream

which is documented in https://protobuf.dev/reference/go/faq/#fix-namespace-conflict

and implemented in https://github.com/protocolbuffers/protobuf-go/blob/03df6c145d9653d4607107dbb3168d05a9b769c8/reflect/protoregistry/registry.go#L30-L42

// conflictPolicy configures the policy for handling registration conflicts.
//
// It can be over-written at compile time with a linker-initialized variable:
//
//	go build -ldflags "-X google.golang.org/protobuf/reflect/protoregistry.conflictPolicy=warn"
//
// It can be over-written at program execution with an environment variable:
//
//	GOLANG_PROTOBUF_REGISTRATION_CONFLICT=warn ./main
//
// Neither of the above are covered by the compatibility promise and
// may be removed in a future release of this module.
var conflictPolicy = "panic" // "panic" | "warn" | "ignore"

@stefanb stefanb added the test failure CI fails while running the test-do block label Sep 18, 2024
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Sep 18, 2024
@stefanb stefanb force-pushed the bump-terrascan-1.19.9 branch from ef5459f to 2c9d880 Compare September 18, 2024 09:03
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Sep 18, 2024
@stefanb stefanb force-pushed the bump-terrascan-1.19.9 branch from 2c9d880 to e144d2a Compare September 18, 2024 09:21
@stefanb stefanb force-pushed the bump-terrascan-1.19.9 branch from e144d2a to 226e3a5 Compare September 18, 2024 09:23
@stefanb stefanb removed the test failure CI fails while running the test-do block label Sep 18, 2024
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Sep 18, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 18, 2024
Merged via the queue into master with commit 408d312 Sep 18, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the bump-terrascan-1.19.9 branch September 18, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. go Go use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants