Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dolt 1.43.0 #191143

Merged
merged 2 commits into from
Sep 19, 2024
Merged

dolt 1.43.0 #191143

merged 2 commits into from
Sep 19, 2024

Conversation

BrewTestBot
Copy link
Member

Created by brew bump


Created with brew bump-formula-pr.

release notes
# Merged PRs

dolt

  • 8367: mark unscoped commit index as not unique
    The index defined over the commit_hash column was marked as unique, when it definitely is not.
    Along with fix from Fix FunctionalDependencies for NonUnique, NonNull indexes on Server dolthub/go-mysql-server#2665
    fixes dolt_diff with commit_hash filter errors with result max1Row iterator returned more than one row dolthub/dolt#8365
  • 8363: \edit support in dolt sql shell
    Enable users to edit multiline queries in their EDITOR of choice. This is awkward to test, so punting on that for the time being.
  • 8359: More flexible diff printing when schema changes type of column
    This partially addresses an old bug described in the fixed issue. There are certainly more complete solutions, but this seems like the right amount of effort for something pretty edge casey.
    Fixes: \diff doesn't handle decimal diffs. It just prints integers. dolthub/dolt#8133
  • 8356: Compare strings with strings.EqualFold
    2024-09-13_23-00
    This PR fixes a Staticcheck warning (https://staticcheck.dev/docs/checks/#SA6005). Comparing two strings to the same case with strings.ToLower and strings.ToUpper is more computational expensive than strings.EqualFold.
    Sample benchmark:
    func BenchmarkToUpperSingle(b *testing.B) {
      for i := 0; i < b.N; i++ {
        if strings.ToUpper("foobar") != "FOOBAR" {
          b.Fail()
        }
      }
    }
    func BenchmarkToUpperDouble(b *testing.B) {
      for i := 0; i < b.N; i++ {
        if strings.ToUpper("foobar") != strings.ToUpper("FOOBAR") {
          b.Fail()
        }
      }
    }
    func BenchmarkToLowerSingle(b *testing.B) {
      for i := 0; i < b.N; i++ {
        if strings.ToLower("FOOBAR") != "foobar" {
          b.Fail()
        }
      }
    }
    func BenchmarkToLowerDouble(b *testing.B) {
      for i := 0; i < b.N; i++ {
        if strings.ToLower("FOOBAR") != strings.ToLower("foobar") {
          b.Fail()
        }
      }
    }
    func BenchmarkEqualFold(b *testing.B) {
      for i := 0; i < b.N; i++ {
        if !strings.EqualFold("FOOBAR", "foobar") {
          b.Fail()
        }
      }
    }
    Result:
    goos: linux
    goarch: amd64
    pkg: github.com/dolthub/dolt/go
    cpu: AMD Ryzen 7 PRO 4750U with Radeon Graphics
    BenchmarkToUpperSingle-16    	 9589896	       113.8 ns/op	       8 B/op	       1 allocs/op
    BenchmarkToUpperDouble-16    	 7097330	       155.9 ns/op	       8 B/op	       1 allocs/op
    BenchmarkToLowerSingle-16    	12346219	       106.5 ns/op	       8 B/op	       1 allocs/op
    BenchmarkToLowerDouble-16    	 8084006	       143.6 ns/op	       8 B/op	       1 allocs/op
    BenchmarkEqualFold-16        	63650023	        18.76 ns/op	       0 B/op	       0 allocs/op
    PASS
    ok  	github.com/dolthub/dolt/go	6.456s
    
  • 8347: Bug fixes for schema names in reset operation
    Also factored some methods into the procedure to make it readable
  • 8305: Support for signed commits.

go-mysql-server

vitess

Closed Issues

  • 8365: dolt_diff with commit_hash filter errors with result max1Row iterator returned more than one row
  • 8133: \diff doesn't handle decimal diffs. It just prints integers.

@github-actions github-actions bot added go Go use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` labels Sep 18, 2024
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Sep 19, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 19, 2024
Merged via the queue into master with commit f1cb4fc Sep 19, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the bump-dolt-1.43.0 branch September 19, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. go Go use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants