Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bump
Created with
brew bump-formula-pr
.release notes
The index defined over the
commit_hash
column was marked as unique, when it definitely is not.Along with fix from Fix FunctionalDependencies for NonUnique, NonNull indexes on Server dolthub/go-mysql-server#2665
fixes
dolt_diff
withcommit_hash
filter errors withresult max1Row iterator returned more than one row
dolthub/dolt#8365dolt sql
shellEnable users to edit multiline queries in their EDITOR of choice. This is awkward to test, so punting on that for the time being.
diff
printing when schema changes type of columnThis partially addresses an old bug described in the fixed issue. There are certainly more complete solutions, but this seems like the right amount of effort for something pretty edge casey.
Fixes:
\diff
doesn't handle decimal diffs. It just prints integers. dolthub/dolt#8133strings.EqualFold
This PR fixes a Staticcheck warning (https://staticcheck.dev/docs/checks/#SA6005). Comparing two strings to the same case with
strings.ToLower
andstrings.ToUpper
is more computational expensive thanstrings.EqualFold
.Sample benchmark:
Also factored some methods into the procedure to make it readable
go-mysql-server
When using the server engine, we return an error for indexes defined over non-unique not null columns.
This meant that filters over these columns would incorrectly return error when there were duplicate entries.
Oddly, this only happens on server engine and not using dolt sql-shell directly.
The bug stems from a missing check when gathering functional dependencies for equalities.
Related:
dolt_diff
withcommit_hash
filter errors withresult max1Row iterator returned more than one row
dolthub/dolt#8365tests on Dolt side for round-trip serialization: [no-release-notes] more stats tests dolthub/dolt#8361
charset()
functionMySQL Docs: https://dev.mysql.com/doc/refman/8.4/en/information-functions.html#function_charset
vitess
Supports the following syntax:
create table t (v blob, vector index(v))
create vector index vec on t(v)
alter table t add vector index vec on t(v)
MySQL Docs: https://dev.mysql.com/doc/refman/8.4/en/date-and-time-functions.html#function_get-format
Closed Issues
dolt_diff
withcommit_hash
filter errors withresult max1Row iterator returned more than one row
\diff
doesn't handle decimal diffs. It just prints integers.