Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

faust 2.75.7 #191308

Closed
wants to merge 1 commit into from
Closed

faust 2.75.7 #191308

wants to merge 1 commit into from

Conversation

BrewTestBot
Copy link
Member

Created by brew bump


Created with brew bump-formula-pr.

@github-actions github-actions bot added the bump-formula-pr PR was created using `brew bump-formula-pr` label Sep 20, 2024
@chenrui333
Copy link
Member

for linux build

  Missing libraries:
    libc.so
    libdl.so
    libm.so
    libstdc++.so

@chenrui333 chenrui333 added linux Linux is specifically affected CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Sep 20, 2024
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Sep 22, 2024
@carlocab
Copy link
Member

Seeing this failure at #181351 too. Seems more like a brew bug since it seems unlikely that a binary can ever have broken linkage to, e.g., libc.

Thoughts here, @Bo98?

@github-actions github-actions bot removed the stale No recent activity label Sep 22, 2024
@Bo98
Copy link
Member

Bo98 commented Sep 22, 2024

Looks like it's picking up the Android (prebuilt) binaries: share/faust/android/app/lib/libsndfile/lib/arm64-v8a/libsndfile.so. Not entirely sure what's changed here though so will poke around.

@carlocab
Copy link
Member

Looks like it's picking up the Android (prebuilt) binaries: share/faust/android/app/lib/libsndfile/lib/arm64-v8a/libsndfile.so. Not entirely sure what's changed here though so will poke around.

Seems to be happening on the existing version of faust too. See #181351

@lukeshingles lukeshingles mentioned this pull request Sep 23, 2024
6 tasks
@cho-m
Copy link
Member

cho-m commented Sep 23, 2024

Could be related to replacing ldd.

An alternative is to just remove files though it may impact Android cross-compilation feature. Arch Linux (and I would guess other Linux distros) went this route. If removing, it should also be removed from

"faust": "share/faust/android/app/lib/libsndfile/lib/*/libsndfile.so",

@Bo98
Copy link
Member

Bo98 commented Sep 24, 2024

Yeah I will add a check that e_machine == current arch which should fix this.

@github-actions github-actions bot added the no Linux bottle Formula has no Linux bottle label Sep 24, 2024
@carlocab carlocab added the ready to merge PR can be merged once CI is green label Sep 24, 2024
@carlocab carlocab added CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. and removed ready to merge PR can be merged once CI is green labels Sep 24, 2024
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Sep 27, 2024
@github-actions github-actions bot closed this Sep 28, 2024
@github-actions github-actions bot deleted the bump-faust-2.75.7 branch September 28, 2024 14:48
carlocab added a commit to Homebrew/brew that referenced this pull request Sep 28, 2024
Some formulae include these files, and they can't always be removed.
However, they can cause spurious linkage failures, so let's skip them
when checking for linkage. See, for example, faust at
Homebrew/homebrew-core#191308.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. linux Linux is specifically affected no Linux bottle Formula has no Linux bottle stale No recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants