Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: add link_overwrite for rustfmt merge #191608

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

carlocab
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Needed after #181351, which merges rustfmt into rust.

Needed after #181351, which merges `rustfmt` into `rust`.
@carlocab carlocab added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Sep 23, 2024
@carlocab carlocab requested a review from cho-m September 23, 2024 18:26
@github-actions github-actions bot added CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. long build Set a long timeout for formula testing long dependent tests Set a long timeout for dependent testing labels Sep 23, 2024
Copy link
Member

@cho-m cho-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me.

Haven't looked too much into this scenario (renaming w/ replacing files), but I wonder if we should add better handling of it in brew if there are any install errors.

@carlocab carlocab added this pull request to the merge queue Sep 23, 2024
Merged via the queue into master with commit b15cef0 Sep 23, 2024
17 checks passed
@carlocab carlocab deleted the rust-link_overwrite branch September 23, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. long build Set a long timeout for formula testing long dependent tests Set a long timeout for dependent testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants