Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

micromamba: bump to 2.0.3 #195371

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Conversation

henryiii
Copy link
Contributor

@henryiii henryiii commented Oct 23, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This is a replacement for #191869 and #192460. This doesn't add a mamba symlink to micromamba, since micromamba and mamba do not have the same interface.

Copy link

request-info bot commented Oct 23, 2024

Please provide a better issue/pull request title and/or description!

@request-info request-info bot added the needs response Needs a response from the issue/PR author label Oct 23, 2024
@daeho-ro
Copy link
Member

daeho-ro commented Oct 25, 2024

  CMake Error at cmake/Checks.cmake:9 (message):
    Expected type "STATIC_LIBRARY" for target "yaml-cpp::yaml-cpp" but found
    "SHARED_LIBRARY"

I noticed that the yaml-cpp is build with the shared option.

def install
system "cmake", ".", *std_cmake_args, "-DYAML_BUILD_SHARED_LIBS=ON",
"-DYAML_CPP_BUILD_TESTS=OFF"
system "make", "install"

Digging more history about why it is build with shared option.

lembacon@6199d97

Maybe no reason :)


From the yaml-cpp documentation,

yaml-cpp builds a static library by default, you may want to build a shared library by specifying -DYAML_BUILD_SHARED_LIBS=ON. ...

so we may require to build and use the static one.

@carlocab
Copy link
Member

We ship the shared libraries according to Homebrew policy: https://docs.brew.sh/Acceptable-Formulae#shared-vs-static-libraries

Formulae should link to shared libraries. There are some intransigent build systems that refuse to do so, but we should fix those wherever we can.

@henryiii henryiii force-pushed the henryiii/chore/micromamba branch from b7376c0 to 1dd060f Compare October 25, 2024 21:15
@carlocab carlocab added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. and removed needs response Needs a response from the issue/PR author labels Oct 25, 2024
@henryiii henryiii force-pushed the henryiii/chore/micromamba branch from 1dd060f to 96c0bf7 Compare October 25, 2024 22:23
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 25, 2024
@henryiii henryiii force-pushed the henryiii/chore/micromamba branch from 96c0bf7 to 7fe14dc Compare October 25, 2024 22:31
@github-actions github-actions bot removed the automerge-skip `brew pr-automerge` will skip this pull request label Oct 25, 2024
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Oct 25, 2024
@henryiii
Copy link
Contributor Author

henryiii commented Nov 6, 2024

This requires C++17, and it looks like macOS 13 & linux are having issues. Is there something that needs to be done for full C++17 support?

macOS 13:

/tmp/micromamba-20241025-6758-psgcn7/mamba-micromamba-2.0.1/libmamba/src/core/transaction.cpp:703:36: error: no viable constructor or deduction guide for deduction of template arguments of 'packaged_task'
                  std::packaged_task task{ [=] { return it->run(); } };

Linux:

Error: /usr/include/c++/11/bits/hashtable_policy.h:1004:12:   required from ‘struct std::__detail::_Insert<std::__cxx11::basic_string<char>, std::pair<const std::__cxx11::basic_string<char>, mamba::specs::Channel>, std::allocator<std::pair<const std::__cxx11::basic_string<char>, mamba::specs::Channel> >, std::__detail::_Select1st, std::equal_to<std::__cxx11::basic_string<char> >, std::hash<std::__cxx11::basic_string<char> >, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true>, false>’
  /usr/include/c++/11/bits/hashtable.h:180:11:   required from ‘class std::_Hashtable<std::__cxx11::basic_string<char>, std::pair<const std::__cxx11::basic_string<char>, mamba::specs::Channel>, std::allocator<std::pair<const std::__cxx11::basic_string<char>, mamba::specs::Channel> >, std::__detail::_Select1st, std::equal_to<std::__cxx11::basic_string<char> >, std::hash<std::__cxx11::basic_string<char> >, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true> >’
  /usr/include/c++/11/bits/unordered_map.h:105:18:   required from ‘class std::unordered_map<std::__cxx11::basic_string<char>, mamba::specs::Channel, std::hash<std::__cxx11::basic_string<char> >, std::equal_to<std::__cxx11::basic_string<char> >, std::allocator<std::pair<const std::__cxx11::basic_string<char>, mamba::specs::Channel> > >’
  /tmp/micromamba-20241025-5716-906661/mamba-micromamba-2.0.1/libmamba/include/mamba/util/weakening_map.hpp:26:11:   required from ‘class mamba::util::weakening_map<std::unordered_map<std::__cxx11::basic_string<char>, mamba::specs::Channel, std::hash<std::__cxx11::basic_string<char> >, std::equal_to<std::__cxx11::basic_string<char> >, std::allocator<std::pair<const std::__cxx11::basic_string<char>, mamba::specs::Channel> > >, mamba::specs::ChannelResolveParams::NameWeakener>’
  /tmp/micromamba-20241025-5716-906661/mamba-micromamba-2.0.1/libmamba/include/mamba/specs/channel.hpp:56:40:   required from here
  /usr/include/c++/11/bits/stl_pair.h:218:11: error: ‘std::pair<_T1, _T2>::second’ has incomplete type
    218 |       _T2 second;                ///< The second member
        |           ^~~~~~
  In file included from /tmp/micromamba-20241025-5716-906661/mamba-micromamba-2.0.1/libmamba/src/specs/channel.cpp:11:
  /tmp/micromamba-20241025-5716-906661/mamba-micromamba-2.0.1/libmamba/include/mamba/specs/channel.hpp:25:11: note: forward declaration of ‘class mamba::specs::Channel’
     25 |     class Channel;
        |           ^~~~~~~
  /tmp/micromamba-20241025-5716-906661/mamba-micromamba-2.0.1/libmamba/src/specs/channel.cpp: In function ‘mamba::specs::Channel::channel_list mamba::specs::{anonymous}::resolve_name(mamba::specs::UnresolvedChannel&&, mamba::specs::ChannelResolveParamsView)’:
  /tmp/micromamba-20241025-5716-906661/mamba-micromamba-2.0.1/libmamba/src/specs/channel.cpp:471:103: error: could not convert ‘{<expression error>}’ from ‘<brace-enclosed initializer list>’ to ‘mamba::specs::Channel::channel_list’ {aka ‘std::vector<mamba::specs::Channel>’}
    471 |                 return { resolve_name_in_custom_channel(std::move(uc), params, it->first, it->second) };
        |                                                                                                       ^
        |                                                                                                       |
        |   

@henryiii henryiii force-pushed the henryiii/chore/micromamba branch from 872db12 to 50eccb3 Compare November 6, 2024 16:59
@henryiii henryiii changed the title micromamba: bump to 2.0.1 micromamba: bump to 2.0.3 Nov 6, 2024
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Nov 6, 2024
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Nov 18, 2024
@henryiii henryiii force-pushed the henryiii/chore/micromamba branch from d0f8d1d to 1cb5a72 Compare November 18, 2024 22:42
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Nov 18, 2024
@henryiii henryiii force-pushed the henryiii/chore/micromamba branch from 1cb5a72 to e17140f Compare November 18, 2024 22:49
@henryiii
Copy link
Contributor Author

henryiii commented Nov 18, 2024

Why is it skipping the testing part?

I've applied mamba-org/mamba#3613. Though I'm having an issue testing this locally, it's quickly quitting and not telling me why.

@SMillerDev
Copy link
Member

Why is it skipping the testing part?

Because of the syntax/style error.

@henryiii henryiii force-pushed the henryiii/chore/micromamba branch from e17140f to 786c454 Compare November 20, 2024 22:39
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Co-authored-by: Carlo Cabrera <github@carlo.cab>
@henryiii henryiii force-pushed the henryiii/chore/micromamba branch from 786c454 to ab811c3 Compare November 20, 2024 22:43
@henryiii
Copy link
Contributor Author

Ahh, missed that, that was it, thanks!

@chenrui333
Copy link
Member

Thanks @henryiii!

Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Nov 25, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Nov 25, 2024
Merged via the queue into Homebrew:master with commit eed5c07 Nov 25, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants