Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flang: speed up CI builds #196319

Merged
merged 1 commit into from
Nov 1, 2024
Merged

flang: speed up CI builds #196319

merged 1 commit into from
Nov 1, 2024

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented Nov 1, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

flang actually takes much longer to build on our arm64 runners than they
do on the x86_64 ones -- likely because the x86_64 runners have more
RAM. Let's try to fix that by limiting the number of concurrent link
jobs spawned during the build.

We do this by setting LLVM_RAM_PER_LINK_JOB, but this requires ninja
to build.

@carlocab carlocab added the CI-no-bottles Merge without publishing bottles label Nov 1, 2024
flang actually takes much longer to build on our arm64 runners than they
do on the x86_64 ones -- likely because the x86_64 runners have more
RAM. Let's try to fix that by limiting the number of concurrent link
jobs spawned during the build.

We do this by setting `LLVM_RAM_PER_LINK_JOB`, but this requires using
`ninja` to build.
@carlocab carlocab added the long build Set a long timeout for formula testing label Nov 1, 2024
@cho-m
Copy link
Member

cho-m commented Nov 1, 2024

I think this made it slower? Taking 6-7 hours now. Previous was 2-3 hours.

@BrewTestBot BrewTestBot added this pull request to the merge queue Nov 1, 2024
Merged via the queue into master with commit d9d97f3 Nov 1, 2024
22 checks passed
@BrewTestBot BrewTestBot deleted the flang-ci-builds branch November 1, 2024 20:12
@carlocab
Copy link
Member Author

carlocab commented Nov 1, 2024

Yea, probably. Should revert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-bottles Merge without publishing bottles long build Set a long timeout for formula testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants