libxml2: fix build when pkg-config is present
#197591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhongRuoyu
added
the
CI-skip-recursive-dependents
github-actions
bot
added
icu4c
ZhongRuoyu
force-pushed
the
libxml2-icu-fix
branch
2 times, most recently
from
2de9503
to
ae30d77
Compare
ZhongRuoyu
force-pushed
the
libxml2-icu-fix
branch
from
ae30d77
to
a032877
Compare
ZhongRuoyu
added
CI-no-fail-fast-deps
ZhongRuoyu
force-pushed
the
libxml2-icu-fix
branch
from
a032877
to
6bd2d03
Compare
When `pkg-config` is present during build, checks for ICU libraries do not work correctly, causing the build to fail. See [1], [2] for more details. Let's apply the patch that fixes this issue. Also, use `pkg-config` for stable builds too. When `pkg-config` is missing, build falls back to using `icu-config` for ICU checks, but that is deprecated upstream [3]. In addition, avoid hard-coding cellar paths that could invalidate dependents' pkg-config files after version bumps. [1]: https://github.com/orgs/Homebrew/discussions/5699#discussioncomment-11243333 [2]: https://gitlab.gnome.org/GNOME/libxml2/-/merge_requests/289 [3]: https://unicode-org.github.io/icu/userguide/icu/howtouseicu.html#notes-on-icu-config
ZhongRuoyu
force-pushed
the
libxml2-icu-fix
branch
from
6bd2d03
to
b48037d
Compare
ZhongRuoyu
added
ready to merge
carlocab
approved these changes
Nov 19, 2024
|
🤖 An automated task has requested bottles to be published to this PR. |
github-actions
bot
added
the
CI-published-bottle-commits
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?When
pkg-configis present during build, checks for ICU libraries do not work correctly, causing the build to fail. See 1, 2 for more details. Let's apply the patch that fixes this issue.Also, use
pkg-configfor stable builds too. Whenpkg-configis missing, build falls back to usingicu-configfor ICU checks, but that is deprecated upstream 3.In addition, avoid hard-coding cellar paths that could invalidate dependents' pkg-config files after version bumps.
Footnotes
https://github.com/orgs/Homebrew/discussions/5699#discussioncomment-11243333 ↩
https://gitlab.gnome.org/GNOME/libxml2/-/merge_requests/289 ↩
https://unicode-org.github.io/icu/userguide/icu/howtouseicu.html#notes-on-icu-config ↩