fdroidserver: add new features #198690
Open
fdroidserver: add new features #198690
+14
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
automerge-skip
eighthave
force-pushed
the
fdroidserver-2.3.0-updates
branch
from
210dad1
to
58e67c4
Compare
chenrui333
reviewed
Nov 23, 2024
Comment on lines
+78
to
+81
| resource "biplist" do | ||
| url "https://files.pythonhosted.org/packages/3e/56/2db170a498c9c6545cda16e93c2f2ef9302da44802787b45a8a520d01bdb/biplist-1.0.3.tar.gz" | ||
| sha256 "4c0549764c5fe50b28042ec21aa2e14fe1a2224e239a1dae77d9e7f3932aa4c6" | ||
| end |
There was a problem hiding this comment.
how did you include this dependency?
when I run brew update-python-resources fdroidserver, it actually got removed.
chenrui333
reviewed
Nov 23, 2024
| @@ -386,8 +397,10 @@ def caveats | |||
| (testpath/"fdroid/config/categories.yml").write <<~YAML | |||
| Development: | |||
| name: Development | |||
| icon: category_development.png | |||
There was a problem hiding this comment.
need to add some dummy files as it failed the test
chenrui333
reviewed
Nov 23, 2024
There was a problem hiding this comment.
might also good to add revision 1 on line 9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some new features are optionally enabled by including the biplist and pycountry libs, and rclone util.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?