o*: migrate to pkgconf

Formula/o/oath-toolkit.rb

@@ -1,4 +1,4 @@
 class OathToolkit < Formula
   desc "Tools for one-time password authentication systems"
   homepage "https://www.nongnu.org/oath-toolkit/"
   url "https://download-mirror.savannah.gnu.org/releases/oath-toolkit/oath-toolkit-2.6.12.tar.gz"
@@ -29,7 +29,7 @@
     depends_on "libtool"  => :build
   end
 
-  depends_on "pkg-config" => :build
+  depends_on "pkgconf" => :build
 
   depends_on "libxml2"
   depends_on "libxmlsec1"

Formula/o/ocp.rb

@@ -1,4 +1,4 @@
 class Ocp < Formula
   desc "UNIX port of the Open Cubic Player"
   homepage "https://stian.cubic.org/project-ocp.php"
   url "https://stian.cubic.org/ocp/ocp-0.2.109.tar.xz"
@@ -22,7 +22,7 @@
     sha256 x86_64_linux:   "4cd81c537874b42e0de929447ecc9fe813030cce6a3b1296caf32309233239bb"
   end
 
-  depends_on "pkg-config" => :build
+  depends_on "pkgconf" => :build
   depends_on "xa" => :build
 
   depends_on "ancient"

Formula/o/ocrmypdf.rb

@@ -16,7 +16,7 @@ class Ocrmypdf < Formula
     sha256 cellar: :any_skip_relocation, x86_64_linux:  "7804f48e5815e641061623b94425e3d15ff89376b69b369b3bd2a9d38965560b"
   end
 
-  depends_on "pkg-config" => :build
+  depends_on "pkgconf" => :build
   depends_on "cryptography"
   depends_on "freetype"
   depends_on "ghostscript"
@@ -36,8 +36,6 @@ class Ocrmypdf < Formula
   uses_from_macos "libxml2", since: :ventura
   uses_from_macos "libxslt"
 
-  fails_with gcc: "5"
-
   resource "charset-normalizer" do
     url "https://files.pythonhosted.org/packages/f2/4f/e1808dc01273379acc506d18f1504eb2d299bd4131743b9fc54d7be4df1e/charset_normalizer-3.4.0.tar.gz"
     sha256 "223217c3d4f82c3ac5e29032b3f1c2eb0fb591b72161f86d93f5719079dae93e"
@@ -123,6 +121,6 @@ def install
   test do
     system bin/"ocrmypdf", "-f", "-q", "--deskew",
                            test_fixtures("test.pdf"), "ocr.pdf"
-    assert_predicate testpath/"ocr.pdf", :exist?
+    assert_path_exists testpath/"ocr.pdf"
   end
 end

Formula/o/octobuild.rb

@@ -1,4 +1,4 @@
 class Octobuild < Formula
   desc "Compiler cache for Unreal Engine"
   homepage "https://github.com/octobuild/octobuild"
   url "https://github.com/octobuild/octobuild/archive/refs/tags/1.5.0.tar.gz"
@@ -18,7 +18,7 @@
   depends_on "rust" => :build
 
   on_linux do
-    depends_on "pkg-config" => :build
+    depends_on "pkgconf" => :build
     depends_on "openssl@3"
   end
 

Formula/o/ode.rb

@@ -1,4 +1,4 @@
 class Ode < Formula
   desc "Simulating articulated rigid body dynamics"
   homepage "https://www.ode.org/"
   url "https://bitbucket.org/odedevs/ode/downloads/ode-0.16.5.tar.gz"
@@ -21,7 +21,7 @@
   depends_on "autoconf" => :build
   depends_on "automake" => :build
   depends_on "libtool" => :build
-  depends_on "pkg-config" => :build
+  depends_on "pkgconf" => :build
   depends_on "libccd"
 
   # Fix -flat_namespace being used on Big Sur and later.

Formula/o/oggz.rb

@@ -1,4 +1,4 @@
 class Oggz < Formula
   desc "Command-line tool for manipulating Ogg files"
   homepage "https://www.xiph.org/oggz/"
   url "https://downloads.xiph.org/releases/liboggz/liboggz-1.1.1.tar.gz", using: :homebrew_curl
@@ -29,7 +29,7 @@
     sha256 cellar: :any_skip_relocation, x86_64_linux:   "d32cc66ca90d54de30392f5c92d7858fd3cb86068a7363ed869aece87f0f9bb1"
   end
 
-  depends_on "pkg-config" => :build
+  depends_on "pkgconf" => :build
   depends_on "libogg"
 
   # Fix -flat_namespace being used on Big Sur and later.
@@ -39,9 +39,7 @@
   end
 
   def install
-    system "./configure", "--prefix=#{prefix}",
-                          "--disable-debug",
-                          "--disable-dependency-tracking"
+    system "./configure", *std_configure_args
     system "make", "install"
   end
 

Formula/o/oha.rb

@@ -1,4 +1,4 @@
 class Oha < Formula
   desc "HTTP load generator, inspired by rakyll/hey with tui animation"
   homepage "https://github.com/hatoo/oha/"
   url "https://github.com/hatoo/oha/archive/refs/tags/v1.4.7.tar.gz"
@@ -16,7 +16,7 @@
   end
 
   depends_on "cmake" => :build # for aws-lc-sys
-  depends_on "pkg-config" => :build
+  depends_on "pkgconf" => :build
   depends_on "rust" => :build
 
   on_linux do

Formula/o/ola.rb

@@ -1,4 +1,4 @@
 class Ola < Formula
   include Language::Python::Shebang
   include Language::Python::Virtualenv
 
@@ -51,7 +51,7 @@
   depends_on "automake" => :build
   depends_on "cppunit" => :build # TODO: remove once we no longer need to run tests
   depends_on "libtool" => :build
-  depends_on "pkg-config" => :build
+  depends_on "pkgconf" => :build
 
   depends_on "abseil"
   depends_on "liblo"

Formula/o/omega.rb

@@ -1,4 +1,4 @@
 class Omega < Formula
   desc "Packaged search engine for websites, built on top of Xapian"
   homepage "https://xapian.org/"
   url "https://oligarchy.co.uk/xapian/1.4.26/xapian-omega-1.4.26.tar.xz"
@@ -21,16 +21,15 @@
     sha256 x86_64_linux:   "8c5d3d4f9b8456a19cff0b0d47f3662734cac29a69a07ece8bdc840fd5a6b253"
   end
 
-  depends_on "pkg-config" => :build
+  depends_on "pkgconf" => :build
   depends_on "libmagic"
   depends_on "pcre2"
   depends_on "xapian"
 
   uses_from_macos "zlib"
 
   def install
-    system "./configure", "--disable-silent-rules",
-                          *std_configure_args.reject { |s| s["--disable-debug"] }
+    system "./configure", "--disable-silent-rules", *std_configure_args
     system "make", "install"
   end
 

Formula/o/omniorb.rb

@@ -20,9 +20,11 @@ class Omniorb < Formula
     sha256 cellar: :any_skip_relocation, x86_64_linux:  "4c9e139a01ab68b128a4cb5ca256ffb4c7f022542cc300e225483675b2a3aed3"
   end
 
-  depends_on "pkg-config" => :build
+  depends_on "pkgconf" => :build
   depends_on "openssl@3"
   depends_on "python@3.13"
+  depends_on "zstd"
+
   uses_from_macos "zlib"
 
   resource "bindings" do

Formula/o/ompl.rb

@@ -26,14 +26,14 @@ class Ompl < Formula
   end
 
   depends_on "cmake" => :build
-  depends_on "pkg-config" => :build
+  depends_on "pkgconf" => :build
   depends_on "boost"
   depends_on "eigen"
   depends_on "flann"
   depends_on "ode"
 
   def install
-    args = std_cmake_args + %w[
+    args = %w[
       -DOMPL_REGISTRATION=OFF
       -DOMPL_BUILD_DEMOS=OFF
       -DOMPL_BUILD_TESTS=OFF
@@ -42,7 +42,7 @@ def install
       -DCMAKE_DISABLE_FIND_PACKAGE_spot=ON
       -DCMAKE_DISABLE_FIND_PACKAGE_Triangle=ON
     ]
-    system "cmake", ".", *args
+    system "cmake", ".", *args, *std_cmake_args
     system "make", "install"
   end
 

Formula/o/onedrive.rb

@@ -10,14 +10,14 @@ class Onedrive < Formula
   end
 
   depends_on "ldc" => :build
-  depends_on "pkg-config" => :build
+  depends_on "pkgconf" => :build
   depends_on "curl"
   depends_on :linux
   depends_on "sqlite"
   depends_on "systemd"
 
   def install
-    system "./configure", *std_configure_args, "--with-systemdsystemunitdir=no"
+    system "./configure", "--with-systemdsystemunitdir=no", *std_configure_args
     system "make", "install"
     bash_completion.install "contrib/completions/complete.bash" => "onedrive"
     zsh_completion.install "contrib/completions/complete.zsh" => "_onedrive"

Formula/o/onefetch.rb

@@ -1,4 +1,4 @@
 class Onefetch < Formula
   desc "Command-line Git information tool"
   homepage "https://onefetch.dev/"
   url "https://github.com/o2sh/onefetch/archive/refs/tags/2.22.0.tar.gz"
@@ -18,7 +18,7 @@
   # `cmake` is used to build `zlib`.
   # upstream issue, https://github.com/rust-lang/libz-sys/issues/147
   depends_on "cmake" => :build
-  depends_on "pkg-config" => :build
+  depends_on "pkgconf" => :build
   depends_on "rust" => :build
   depends_on "zstd"
 

Formula/o/onlykey-agent.rb

@@ -18,7 +18,7 @@ class OnlykeyAgent < Formula
     sha256 cellar: :any_skip_relocation, x86_64_linux:  "64d86873e97fa9e89aa54cbf77ef7ee139696fe68b93ed7664fd1b7c690c659a"
   end
 
-  depends_on "pkg-config" => :build
+  depends_on "pkgconf" => :build
   depends_on "certifi"
   depends_on "cryptography"
   depends_on "gnupg"
@@ -193,8 +193,6 @@ class OnlykeyAgent < Formula
   end
 
   def install
-    ENV["HIDAPI_SYSTEM_HIDAPI"] = "1"
-    ENV["SODIUM_INSTALL"] = "system"
     virtualenv_install_with_resources
   end
 

Formula/o/open-adventure.rb

@@ -31,7 +31,7 @@ class OpenAdventure < Formula
   uses_from_macos "libedit"
 
   on_linux do
-    depends_on "pkg-config" => :build
+    depends_on "pkgconf" => :build
   end
 
   resource "pyyaml" do

Formula/o/open-babel.rb

@@ -27,7 +27,7 @@ class OpenBabel < Formula
   end
 
   depends_on "cmake" => :build
-  depends_on "pkg-config" => :build
+  depends_on "pkgconf" => :build
   depends_on "rapidjson" => :build
   depends_on "swig" => :build
 

Formula/o/open-ocd.rb

@@ -33,7 +33,7 @@ class OpenOcd < Formula
     depends_on "texinfo" => :build
   end
 
-  depends_on "pkg-config" => :build
+  depends_on "pkgconf" => :build
   depends_on "capstone"
   depends_on "hidapi"
   depends_on "libftdi"
@@ -43,13 +43,12 @@ def install
     ENV["CCACHE"] = "none"
 
     system "./bootstrap", "nosubmodule" if build.head?
-    system "./configure", "--disable-dependency-tracking",
-                          "--prefix=#{prefix}",
-                          "--enable-buspirate",
+    system "./configure", "--enable-buspirate",
                           "--enable-stlink",
                           "--enable-dummy",
                           "--enable-jtag_vpi",
-                          "--enable-remote-bitbang"
+                          "--enable-remote-bitbang",
+                          *std_configure_args
     system "make", "install"
   end
 end

Formula/o/open-scene-graph.rb

@@ -33,13 +33,14 @@ class OpenSceneGraph < Formula
   depends_on "cmake" => :build
   depends_on "doxygen" => :build
   depends_on "graphviz" => :build
-  depends_on "pkg-config" => :build
+  depends_on "pkgconf" => :build
 
   depends_on "fontconfig"
   depends_on "freetype"
   depends_on "jpeg-turbo"
   depends_on "sdl2"
 
+  uses_from_macos "curl"
   uses_from_macos "zlib"
 
   on_linux do
@@ -94,11 +95,10 @@ def install
       #include <iostream>
       #include <osg/Version>
       using namespace std;
-      int main()
-        {
+      int main() {
           cout << osgGetVersion() << endl;
           return 0;
-        }
+      }
     CPP
     system ENV.cxx, "test.cpp", "-I#{include}", "-L#{lib}", "-losg", "-o", "test"
     assert_match version.to_s, shell_output("./test")

Formula/o/open-tyrian.rb

@@ -20,7 +20,7 @@ class OpenTyrian < Formula
     sha256 x86_64_linux:   "20d32afb8db3ce9038cdbc8424c16a081b93e0060ac43f35a3d62bcde0c54fbd"
   end
 
-  depends_on "pkg-config" => :build
+  depends_on "pkgconf" => :build
   depends_on "sdl2"
   depends_on "sdl2_net"
 

Formula/o/openal-soft.rb

@@ -23,18 +23,18 @@ class OpenalSoft < Formula
   keg_only :shadowed_by_macos, "macOS provides OpenAL.framework"
 
   depends_on "cmake" => :build
-  depends_on "pkg-config" => :build
+  depends_on "pkgconf" => :build
 
   def install
     # Please don't re-enable example building. See:
     # https://github.com/Homebrew/homebrew/issues/38274
-    args = %w[
+    args = %W[
       -DALSOFT_BACKEND_PORTAUDIO=OFF
       -DALSOFT_BACKEND_PULSEAUDIO=OFF
       -DALSOFT_EXAMPLES=OFF
       -DALSOFT_MIDI_FLUIDSYNTH=OFF
+      -DCMAKE_INSTALL_RPATH=#{rpath}
     ]
-    args << "-DCMAKE_INSTALL_RPATH=#{rpath}"
 
     system "cmake", "-S", ".", "-B", "build", *args, *std_cmake_args
     system "cmake", "--build", "build"

Formula/o/opencbm.rb

@@ -24,7 +24,7 @@ class Opencbm < Formula
   # cc65 is only used to build binary blobs included with the programs; it's
   # not necessary in its own right.
   depends_on "cc65" => :build
-  depends_on "pkg-config" => :build
+  depends_on "pkgconf" => :build
   depends_on "libusb"
 
   uses_from_macos "ncurses"

Formula/o/opencv.rb

@@ -1,4 +1,4 @@
 class Opencv < Formula
   desc "Open source computer vision library"
   homepage "https://opencv.org/"
   url "https://github.com/opencv/opencv/archive/refs/tags/4.10.0.tar.gz"
@@ -21,7 +21,7 @@
   end
 
   depends_on "cmake" => :build
-  depends_on "pkg-config" => :build
+  depends_on "pkgconf" => :build
   depends_on "python-setuptools" => :build
   depends_on "abseil"
   depends_on "ceres-solver"
@@ -62,8 +62,6 @@
     depends_on "gtk+3"
   end
 
-  fails_with gcc: "5" # ffmpeg is compiled with GCC
-
   resource "contrib" do
     url "https://github.com/opencv/opencv_contrib/archive/refs/tags/4.10.0.tar.gz"
     sha256 "65597f8fb8dc2b876c1b45b928bbcc5f772ddbaf97539bf1b737623d0604cba1"

Formula/o/opendht.rb

@@ -26,7 +26,7 @@ class Opendht < Formula
   end
 
   depends_on "cmake" => :build
-  depends_on "pkg-config" => :build
+  depends_on "pkgconf" => :build
   depends_on "argon2"
   depends_on "asio"
   depends_on "fmt"
@@ -35,8 +35,6 @@ class Opendht < Formula
   depends_on "nettle"
   depends_on "readline"
 
-  fails_with gcc: "5"
-
   def install
     system "cmake", "-S", ".", "-B", "build",
                     "-DOPENDHT_C=ON",

Formula/o/openexr.rb

@@ -1,4 +1,4 @@
 class Openexr < Formula
   desc "High dynamic-range image file format"
   homepage "https://www.openexr.com/"
   url "https://github.com/AcademySoftwareFoundation/openexr/archive/refs/tags/v3.3.2.tar.gz"
@@ -15,7 +15,7 @@
   end
 
   depends_on "cmake" => :build
-  depends_on "pkg-config" => :build
+  depends_on "pkgconf" => :build
 
   depends_on "imath"
   depends_on "libdeflate"

Formula/o/openfortivpn.rb

@@ -19,19 +19,18 @@ class Openfortivpn < Formula
 
   depends_on "autoconf" => :build
   depends_on "automake" => :build
-  depends_on "pkg-config" => :build
+  depends_on "pkgconf" => :build
   depends_on "openssl@3"
 
   # awaiting formula creation
   # uses_from_macos "pppd"
 
   def install
     system "./autogen.sh"
-    system "./configure", "--disable-dependency-tracking",
-                          "--disable-silent-rules",
+    system "./configure", "--disable-silent-rules",
                           "--enable-legacy-pppd", # only for pppd < 2.5.0
-                          "--prefix=#{prefix}",
-                          "--sysconfdir=#{etc}/openfortivpn"
+                          "--sysconfdir=#{etc}/openfortivpn",
+                          *std_configure_args
     system "make", "install"
   end
 

Formula/o/openfpgaloader.rb

@@ -18,7 +18,7 @@ class Openfpgaloader < Formula
   end
 
   depends_on "cmake" => :build
-  depends_on "pkg-config" => :build
+  depends_on "pkgconf" => :build
   depends_on "libftdi"
   depends_on "libusb"