Remove unnecessary PyPI livecheck blocks #200654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing `livecheck` block for `asciidoc` checks the `head` Git repository tags but the `stable` URL is a PyPI package. This removes the `livecheck` block, as the default `Pypi` check works as expected and this will align the check with the `stable` source.
The existing `livecheck` block for `bagit` uses the `Pypi` strategy to identify the newest version but this regex is no longer necessary or appropriate for the current implementation of the strategy. This removes the `livecheck` block accordingly.
The existing `livecheck` block for `black` uses the `Pypi` strategy to identify the newest version but this regex is no longer necessary or appropriate for the current implementation of the strategy. This removes the `livecheck` block accordingly.
The existing `livecheck` block for `cfn-lint` uses the `Pypi` strategy to identify the newest version but this regex is no longer necessary or appropriate for the current implementation of the strategy. This removes the `livecheck` block accordingly.
The existing `livecheck` block for `isort` uses the `Pypi` strategy to identify the newest version but this regex is no longer necessary or appropriate for the current implementation of the strategy. This removes the `livecheck` block accordingly.
samford
added
livecheck
github-actions
bot
added
the
python
bevanjkay
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?We recently changed the way livecheck's
Pypistrategy identifies the newest version for a project (Homebrew/brew#18895). The initial implementation of the change didn't support a regex, so the formulae using thePypistrategy with alivecheckblock containing a regex worked fine. However, I added regex support back to the strategy (Homebrew/brew#18903), so now those checks are failing because the regex isn't appropriate for the new context. This removes theselivecheckblocks from related formulae, as the regex is no longer necessary to identify the newest version (the default strategy behavior is sufficient).Besides that, this removes the
livecheckblock fromasciidocas it is checking theheadGit tags but thestableURL is a PyPI package. Removing thelivecheckblock allows livecheck to use thePypistrategy with thestableURL by default. This works as expected and aligns the check with thestablesource.