Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opencv: drop workarounds, update test to use shared lib #208693

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Feb 23, 2025

Not sure what original reason for PYTHONPATH workaround but brew should sanitize environment variables. Within brew, only Language::Python.each_python manipulates PYTHONPATH but that isn't used within official taps.

Protobuf workarounds haven't been needed since 4.9.0 opencv/opencv@6e4280e

Test has been a simple version check which we usually don't like. Added a minor update to at least try using part of API that need shared libraries (some of https://docs.opencv.org/4.11.0/db/deb/tutorial_display_image.html). May be worth expanding to a larger example that uses more features.


Also trying to see if failure in #208051 is specific to those changes.

@cho-m cho-m added the CI-no-bottles Merge without publishing bottles label Feb 23, 2025
@github-actions github-actions bot added python Python use is a significant feature of the PR or issue ffmpeg FFMPEG use is a significant feature of the PR or issue labels Feb 23, 2025
@cho-m
Copy link
Member Author

cho-m commented Feb 23, 2025

Same failure as other PR with unrelated set of changes. May be something else changed and has broken binaries:

  ==> python3.13 -c 'import cv2; print(cv2.__version__)'
  WARNING: All log messages before absl::InitializeLog() is called are written to STDERR
  E0000 00:00:1740341130.525890   53511 descriptor_database.cc:550] Invalid file descriptor data passed to EncodedDescriptorDatabase::Add().
  F0000 00:00:1740341130.525922   53511 descriptor.cc:2248] Check failed: GeneratedDatabase()->Add(encoded_file_descriptor, size) 
  *** Check failure stack trace: ***
  Aborted (core dumped)

We did successfully build OpenCV recently (Feb 7th).

No changes in python@3.13, protobuf or abseil which is part of above error message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-bottles Merge without publishing bottles ffmpeg FFMPEG use is a significant feature of the PR or issue python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant