opencv: drop workarounds, update test to use shared lib #208693
Draft
+9
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure what original reason for PYTHONPATH workaround but brew should sanitize environment variables. Within brew, only
Language::Python.each_python
manipulates PYTHONPATH but that isn't used within official taps.Protobuf workarounds haven't been needed since 4.9.0 opencv/opencv@6e4280e
Test has been a simple version check which we usually don't like. Added a minor update to at least try using part of API that need shared libraries (some of https://docs.opencv.org/4.11.0/db/deb/tutorial_display_image.html). May be worth expanding to a larger example that uses more features.
Also trying to see if failure in #208051 is specific to those changes.