Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

traefik: switch to containous/go-bindata #23876

Merged
merged 1 commit into from
Feb 9, 2018
Merged

traefik: switch to containous/go-bindata #23876

merged 1 commit into from
Feb 9, 2018

Conversation

commitay
Copy link
Contributor

@commitay commitay commented Feb 9, 2018

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

cc @ilovezfs

@fxcoudert fxcoudert added the go Go use is a significant feature of the PR or issue label Feb 9, 2018
@ilovezfs
Copy link
Contributor

ilovezfs commented Feb 9, 2018

I sure hope the community can standardize on one version of this :(

@ilovezfs ilovezfs merged commit 94520a0 into Homebrew:master Feb 9, 2018
@ilovezfs
Copy link
Contributor

ilovezfs commented Feb 9, 2018

Thanks @commitay!

@commitay
Copy link
Contributor Author

commitay commented Feb 9, 2018

I sure hope the community can standardize on one version of this :(

It would be nice!

I've been looking at other (non-Homebrew) stuff that uses bindata, they are mostly switching to using their own forks. A couple are moving over to https://github.com/gobuffalo/packr or go-statik.


gitlab-runner has https://gitlab.com/gitlab-org/gitlab-runner/issues/3077 open.

goad hasn't had any activity in their repo since october.

@commitay commitay deleted the traefik branch February 9, 2018 10:54
@DomT4
Copy link
Contributor

DomT4 commented Feb 10, 2018

FWIW https://github.com/jteeuwen/go-bindata/ is back, although it's not the same user despite the username being the same. See: jteeuwen/go-bindata#5.

@ilovezfs
Copy link
Contributor

We know ;) #23803 (comment)

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
go Go use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants