Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ammonite-repl: Add shebang to amm executable #28053

Closed
wants to merge 1 commit into from

Conversation

mdedetrich
Copy link

@mdedetrich mdedetrich commented May 20, 2018

New versions of the ammonite-repl don't include the shebag inside the executable which means it fails to execute if you aren't in a Bourne compliant shell (such as fish)

This fixes com-lihaoyi/Ammonite#813

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

New versions of the ammonite-repl don't include the shebag inside the executable which means it fails to execute if you aren't in a Bourne compliant shell (such as fish)
@ilovezfs
Copy link
Contributor

This is an upstream issue. We shouldn't need to prepend shebang lines.

@ilovezfs ilovezfs closed this May 20, 2018
@ilovezfs
Copy link
Contributor

Thanks for the PR nonetheless @mdedetrich!

@mdedetrich
Copy link
Author

@ilovezfs Incase it takes upstream for a while, is it possible to fix the formula for the current release (and if so, is this something that is done using patch or is the approach used in this PR acceptable?)

@ilovezfs
Copy link
Contributor

@mdedetrich let's see what upstream says first.

@mdedetrich
Copy link
Author

mdedetrich commented May 20, 2018

@ilovezfs Upstream commented, basically it will take a while to post a fix (the reason why the script doesn't have the shebang in there is because it was universally for both *nix/MacOSX and Windows). I am going to do a PR to fix the changes but its not trivial (I am also on vacation currently).

I am not sure what the rules are in regards to temporary fixes, note that this PR is meant to idempotent (i.e. it will only add the shebang if it doesn't exist), so if it gets fixed at some point in the future nothing will break.

There is also an argument from upstream that this is the responsibility of the OS installing the library rather than the release of the library itself (in the same way that we have the chmod files, which is perfectly acceptable)

@lock lock bot added the outdated PR was locked due to age label Jun 19, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ammonite not working under fish shell
2 participants