Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node@6 6.16.0 #35489

Closed
wants to merge 1 commit into from
Closed

node@6 6.16.0 #35489

wants to merge 1 commit into from

Conversation

chrmoritz
Copy link
Contributor

@chrmoritz chrmoritz commented Dec 27, 2018

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

continuation of #34674

This bumps the MACOSX_DEPLOYMENT_TARGET in common.gypi to the actual macOS version to avoid building against the deprecated (and in XCode 10.1 removed) libstdc++ instead of libc++, which would break building native addons.
We also need to set the nodedir npm config options so that our common.gypi (and headers from include) are used by node-gyp instead of the ones downloaded on demand from the official header tarball (which still has the old MACOSX_DEPLOYMENT_TARGET set in their common.gypi).

@fxcoudert
Copy link
Member

Looking good, thanks @chrmoritz

@fxcoudert fxcoudert closed this in 4f6e3e1 Dec 27, 2018
@lock lock bot added the outdated PR was locked due to age label Jan 26, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants