Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install <formula>
)?continuation of #34674
This bumps the
MACOSX_DEPLOYMENT_TARGET
incommon.gypi
to the actual macOS version to avoid building against the deprecated (and in XCode 10.1 removed)libstdc++
instead oflibc++
, which would break building native addons.We also need to set the
nodedir
npm config options so that ourcommon.gypi
(and headers frominclude
) are used bynode-gyp
instead of the ones downloaded on demand from the official header tarball (which still has the oldMACOSX_DEPLOYMENT_TARGET
set in theircommon.gypi
).