-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: wdt 1.27.1612021-145-gbc22626 (new formula) #39345
Conversation
Formula/wdt.rb
Outdated
depends_on "glog" | ||
depends_on "openssl" | ||
|
||
resource "folly" do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have a folly
formula, please depend on that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It requires cpp files from Folly to build, which is why it requires folly formula (for headers) and also resources folly (for headers and cpps during build time). I have no idea what the best way to resolve that is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think maybe something could be changed upstream to link against a full version of folly rather than building libfolly4wdt, which seems to be a subset of the whole lib. I made an issue here facebook/wdt#194
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added a patch here to cover building against full folly and removing the resource. I am going to try to get something similar upstream.
Changed to WIP until I can get patches together here or upstream to build against and link full folly. |
|
Thanks everyone for reviewing this. It seems the upstream developers at Facebook are pretty unresponsive. https://github.com/facebook/wdt I am going to close this for now as there is no sensible way to merge without patches. |
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install <formula>
)?This is very similar to an old pull request here Homebrew/legacy-homebrew#50381
The patch from the old one is no longer needed but other comments on there are not resolved in this version (see https://discourse.brew.sh/t/need-help-making-wdt-formula/4700)