grin-wallet 2.1.0 (new formula)

[quentinlesceller]

• Have you followed the guidelines for contributing?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

---

[SMillerDev]

We need a test that exercises the some of the functionality of the app. Version checks or usage checks (foo --version or foo --help) are not sufficient, as explained in the formula cookbook.

In most cases, a good test would involve running a simple test case: run #{bin}/foo input.txt.

• Then you can check that the output is as expected (with assert_equal or assert_match on the output of shell_output)
• You can also check that an output file was created, if that is expected: assert_predicate testpath/"output.txt", :exist?

Some advice for specific cases:

• If the formula is a library, compile and run some simple code that links against it. It could be taken from upstream's documentation / source examples.
• If the formula is for a GUI program, try to find some function that runs as command-line only, like a format conversion, reading or displaying a config file, etc.
• If the software cannot function without credentials, a test could be to try to connect with invalid credentials (or without credentials) and confirm that it fails as expected.
• Same if the software requires a virtual machine, docker instance, etc. to be running.

[quentinlesceller]

Hi @SMillerDev I just addressed this in the latest commit.

[zachauten]

Please squash the branch down to a single commit.

[quentinlesceller]

@zachauten Thanks. Squashed to a single commit.

[zbeekman]

If you agree with my suggestion, can you please make the change and squash/fixup the commit? Should be ready to go after that.

[quentinlesceller]

Agree with the suggestion. Changed and squashed.

[zbeekman]

LGTM, but is it possible to add --lock to the cargo install command? Does upstream provide a cargo.lock file?

[zbeekman]

LGTM

[chenrui333]

Thanks all, merging now!