Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffsend: Bump version and add --locked flag to cargo install #46139

Closed

Conversation

samford
Copy link
Member

@samford samford commented Nov 2, 2019

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Related to #46025 but I also bumped the version to v0.2.55 in the process of adding the --locked flag to cargo install.

@fxcoudert
Copy link
Member

Thanks @samford!

PS: when the version change, we want the commit message to be formula x.y.z (even if there are other changes). This makes it easier to grep for version changes in git logs, for one thing.

@fxcoudert fxcoudert closed this in 973f7cd Nov 3, 2019
@samford samford deleted the ffsend-bump-version-locked-flag branch November 3, 2019 03:27
@lock lock bot added the outdated PR was locked due to age label Jan 3, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants