Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-series: add --locked flag to cargo install #46176

Closed

Conversation

chenrui333
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Relates to #46025

@samford
Copy link
Member

samford commented Nov 3, 2019

The CI build is failing here because the lock file in git-series v0.9.1 (latest) uses an old version of git2, which uses an old version of libgit2-sys, which uses an old version of openssl-sys that has a build error.

The v0.9.1 release is nearly three years old now, so it's no surprise that the build fails. It looks like the creator started working on it again in October and added a number of commits, one of which bumps the git2 version and fixes this issue.

I would say it's best not to add the --locked flag in the current state and to wait for a new release. It's possible to build from master but, because of the recent changes, it may not be fully ready for use.

@chenrui333
Copy link
Member Author

@samford Sounds good, let's do it in the new release!

@chenrui333 chenrui333 closed this Nov 3, 2019
@lock lock bot added the outdated PR was locked due to age label Jan 3, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 3, 2020
@chenrui333 chenrui333 deleted the git-series-add-locked-flag branch December 18, 2022 04:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants