Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luajit: fix on Catalina #46928

Closed
wants to merge 2 commits into from
Closed

luajit: fix on Catalina #46928

wants to merge 2 commits into from

Conversation

clason
Copy link
Contributor

@clason clason commented Nov 19, 2019

backport lj_alloc.c from 2.1 branch to 2.0.5, required to make luajit stable work on Catalina

see #46823
and LuaJIT/LuaJIT#521

cc @fxcoudert

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

backport lj_alloc.c from 2.1 branch to 2.0.5, required to make
luajit stable work on Catalina

see #46823
and LuaJIT/LuaJIT#521
@fxcoudert
Copy link
Member

Thanks @clason
Can you confirm that this build passes locally and fixes your issues?

@clason
Copy link
Contributor Author

clason commented Nov 20, 2019

@fxcoudert Yes, I just double-checked. brew install luajit -s compiles and works on Catalina, which in turn fixes neovim (bottled and built).

@clason
Copy link
Contributor Author

clason commented Nov 20, 2019

Oh, and do I have to do something special to get the Catalina bottle rebuilt from this formula? The bottle block is autogenerated on merge, right?

Formula/luajit.rb Outdated Show resolved Hide resolved
@fxcoudert
Copy link
Member

Bottles will be automatically regenerated.

@clason clason requested a review from fxcoudert November 21, 2019 10:29
@fxcoudert fxcoudert closed this in 8cd1431 Nov 21, 2019
@clason clason deleted the luajit-catalina branch November 21, 2019 13:12
@lock lock bot added the outdated PR was locked due to age label Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants