Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

circleci: remove gopath #47672

Closed
wants to merge 1 commit into from
Closed

Conversation

alebcay
Copy link
Member

@alebcay alebcay commented Dec 10, 2019

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Remove GOPATH as formula supports Go modules.

Relates to #47627.

@alebcay
Copy link
Member Author

alebcay commented Dec 10, 2019

==> brew test circleci --verbose
==> FAILED
Testing circleci
/usr/bin/sandbox-exec -f /private/tmp/homebrew20191210-19705-ttsrzo.sb ruby -W0 -I $LOAD_PATH -- /usr/local/Homebrew/Library/Homebrew/test.rb /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/circleci.rb --verbose
==> /usr/local/Cellar/circleci/0.1.5879/bin/circleci version
panic: stat /private/tmp/_data/data.yml: no such file or directory

goroutine 1 [running]:
github.com/CircleCI-Public/circleci-cli/cmd.MakeCommands(0xc000094058)
	github.com/CircleCI-Public/circleci-cli@/cmd/root.go:88 +0xe2e
github.com/CircleCI-Public/circleci-cli/cmd.Execute()
	github.com/CircleCI-Public/circleci-cli@/cmd/root.go:36 +0x22
main.main()
	github.com/CircleCI-Public/circleci-cli@/main.go:9 +0x20
Error: circleci: failed
An exception occurred within a child process:
  Test::Unit::AssertionFailedError: <0> expected but was
<2>.

Reproduced issue locally. Attempted removing the added -trimpath but issue persisted, so the error is arising from the actual removal of GOPATH, not just the change in flags.

@alebcay alebcay added the gopath deprecation Deprecate GOPATH in favor of Go Modules label Dec 10, 2019
@stale
Copy link

stale bot commented Jan 2, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale No recent activity label Jan 2, 2020
@alebcay alebcay closed this Jan 2, 2020
@lock lock bot added the outdated PR was locked due to age label Feb 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
gopath deprecation Deprecate GOPATH in favor of Go Modules outdated PR was locked due to age stale No recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant