-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sile 0.10.3 #49744
sile 0.10.3 #49744
Conversation
See upstream release checklist and issue about git HEAD builds needing history. |
@simoncozens I attempted a fix here for the Lua path issue. I think the wrapper script should now just prepend its own paths instead of completely clobbering what Lua would otherwise have had. I am completely unable to test this though so I'm leaving the PR in draft mode for now until there is some confirmation that it works. |
If this works, another thing to try and simplify (and avoid the Lua invocations) is this: diff --git a/Formula/sile.rb b/Formula/sile.rb
index 3909af5e6b..90501c13ce 100644
--- a/Formula/sile.rb
+++ b/Formula/sile.rb
@@ -139,8 +139,8 @@ class Sile < Formula
(libexec/"bin").install bin/"sile"
(bin/"sile").write <<~EOS
#!/bin/bash
- export LUA_PATH="#{ENV["LUA_PATH"]};$(lua -e 'print(package.path)')"
- export LUA_CPATH="#{ENV["LUA_CPATH"]};$(lua -e 'print(package.cpath)')"
+ export LUA_PATH="#{ENV["LUA_PATH"]};;"
+ export LUA_CPATH="#{ENV["LUA_CPATH"]};;"
"#{libexec}/bin/sile" "$@"
EOS
end The double |
PR as written works fine. Checking the suggested patch now. |
Double-semicolon solution also seems to work. |
@simoncozens Thanks. The double-semicolon trick is less process overhead so we'll go with that. |
Looks good, can you squash your commits? |
@SMillerDev Done. |
It seems like CI got stuck, it has been "pending" for a day. I'm rebasing on master just to poke it (since I don't have any other way of triggering it to retry). |
* Bump version to latest upstream release * Add missing Luarock dependency * Require git history for HEAD builds * Prefix rather than occlude Lua paths in wrapper Co-authored-by: Simon Cozens <simon@simon-cozens.org>
Hey looks like that worked. If there is a different way to un-jam CI checks that never return I'd be happy to learn. |
You can ask |
Thanks @alerque!! |
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install <formula>
)?