Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bzt 1.14.1 #51521

Closed
wants to merge 1 commit into from
Closed

bzt 1.14.1 #51521

wants to merge 1 commit into from

Conversation

chenrui333
Copy link
Member

Created with brew bump-formula-pr.

@chenrui333 chenrui333 mentioned this pull request Mar 11, 2020
5 tasks
@chenrui333 chenrui333 force-pushed the bzt-1.14.1 branch 2 times, most recently from dba05b3 to bfd2cbf Compare March 11, 2020 01:38
@chenrui333
Copy link
Member Author

Run into test failure with python 3.8

[2020-03-10 21:35:22,120 ERROR root] AttributeError: 'Constant' object has no attribute 'kind'
  File "/usr/local/Cellar/bzt/1.14.1/libexec/lib/python3.8/site-packages/bzt/cli.py", line 258, in perform
    self.engine.prepare()
  File "/usr/local/Cellar/bzt/1.14.1/libexec/lib/python3.8/site-packages/bzt/engine/engine.py", line 195, in prepare
    self.__prepare_provisioning()
  File "/usr/local/Cellar/bzt/1.14.1/libexec/lib/python3.8/site-packages/bzt/engine/engine.py", line 591, in __prepare_provisioning
    self.provisioning.prepare()
  File "/usr/local/Cellar/bzt/1.14.1/libexec/lib/python3.8/site-packages/bzt/modules/provisioning.py", line 73, in prepare
    executor.prepare()
  File "/usr/local/Cellar/bzt/1.14.1/libexec/lib/python3.8/site-packages/bzt/modules/apiritif/executor.py", line 62, in prepare
    self.script = self.__tests_from_requests()
  File "/usr/local/Cellar/bzt/1.14.1/libexec/lib/python3.8/site-packages/bzt/modules/apiritif/executor.py", line 110, in __tests_from_requests
    builder.save(filename)
  File "/usr/local/Cellar/bzt/1.14.1/libexec/lib/python3.8/site-packages/bzt/modules/apiritif/generator.py", line 1429, in save
    fds.write(astunparse.unparse(self.tree))
  File "/usr/local/Cellar/bzt/1.14.1/libexec/lib/python3.8/site-packages/astunparse/__init__.py", line 13, in unparse
    Unparser(tree, file=v)
  File "/usr/local/Cellar/bzt/1.14.1/libexec/lib/python3.8/site-packages/astunparse/unparser.py", line 38, in __init__
    self.dispatch(tree)
  File "/usr/local/Cellar/bzt/1.14.1/libexec/lib/python3.8/site-packages/astunparse/unparser.py", line 66, in dispatch
    meth(tree)
  File "/usr/local/Cellar/bzt/1.14.1/libexec/lib/python3.8/site-packages/astunparse/unparser.py", line 78, in _Module
    self.dispatch(stmt)
  File "/usr/local/Cellar/bzt/1.14.1/libexec/lib/python3.8/site-packages/astunparse/unparser.py", line 66, in dispatch
    meth(tree)
  File "/usr/local/Cellar/bzt/1.14.1/libexec/lib/python3.8/site-packages/astunparse/unparser.py", line 120, in _Assign
    self.dispatch(t.value)
  File "/usr/local/Cellar/bzt/1.14.1/libexec/lib/python3.8/site-packages/astunparse/unparser.py", line 66, in dispatch
    meth(tree)
  File "/usr/local/Cellar/bzt/1.14.1/libexec/lib/python3.8/site-packages/astunparse/unparser.py", line 723, in _Call
    self.dispatch(e)
  File "/usr/local/Cellar/bzt/1.14.1/libexec/lib/python3.8/site-packages/astunparse/unparser.py", line 66, in dispatch
    meth(tree)
  File "/usr/local/Cellar/bzt/1.14.1/libexec/lib/python3.8/site-packages/astunparse/unparser.py", line 551, in _Constant
    if t.kind == "u":

@chenrui333
Copy link
Member Author

relates to simonpercivall/astunparse#43

@chenrui333
Copy link
Member Author

Should be fixed now. It can only run with python 3.7 at this moment.

@Bo98
Copy link
Member

Bo98 commented Mar 11, 2020

Can we wait until #50712 is merged (or the CI fails) to avoid merge conflicts?

@chenrui333
Copy link
Member Author

chenrui333 commented Mar 11, 2020

Just FYI, the latest update of this formula does not live well with python 3.8

@chenrui333
Copy link
Member Author

we can chat about this tomorrow, I am totally ok with the python upgrade first.

@Bo98
Copy link
Member

Bo98 commented Mar 11, 2020

I think I can get this merged at the same time with some git rebase work and being careful about the bottle.

@Bo98 Bo98 closed this in e00f8e3 Mar 11, 2020
@lock lock bot added the outdated PR was locked due to age label Apr 15, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
@chenrui333 chenrui333 deleted the bzt-1.14.1 branch December 18, 2022 04:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants