Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node 14.1.0 #54008

Closed
wants to merge 1 commit into from
Closed

node 14.1.0 #54008

wants to merge 1 commit into from

Conversation

rwoll
Copy link
Contributor

@rwoll rwoll commented Apr 29, 2020

Created with brew bump-formula-pr.

@rwoll
Copy link
Contributor Author

rwoll commented Apr 29, 2020

Node 14.0.0 (the current install target of brew install node) breaks several stream based libs (max-mapper/extract-zip#94 (comment)); 14.1.0 patches some of the breaking changes.

Related: max-mapper/extract-zip#94, microsoft/playwright#1988

@rwoll
Copy link
Contributor Author

rwoll commented Apr 30, 2020

@issyl0 Could you help me determine the bottle SHAs for this latest update?

At first I looked here https://nodejs.org/dist/v14.1.0/SHASUMS256.txt, but the previous revision doesn't have the previous bottle hashes, so I'm assuming the bottles are different artifacts.

@rwoll
Copy link
Contributor Author

rwoll commented Apr 30, 2020

At first I looked here https://nodejs.org/dist/v14.1.0/SHASUMS256.txt, but the previous revision doesn't have the previous bottle hashes, so I'm assuming the bottles are different artifacts.

Ah, just read more on what bottles are and now realize they wouldn't be in Node's official repo. Based on https://github.com/Homebrew/brew/blob/master/docs/Bottles.md#creation, it looks like the bottle SHAs will get updated out of band once a Hombrew Team Member triggers a bot build. Is that correct, or should future MRs include the bottle SHA bumps?

@Bo98
Copy link
Member

Bo98 commented Apr 30, 2020

Is that correct

Yes, you do not need to touch any part of the bottle block. It is automatically modified while merging (we don’t merge via GitHub UI).

@BrewTestBot
Copy link
Member

:shipit: @Bo98 has triggered a merge.

@Bo98
Copy link
Member

Bo98 commented Apr 30, 2020

Thanks! Here's the automatic bottle commit if you are interested: 5a846a7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants