qt5 5.6.2

[ilovezfs]

Created with brew bump-formula-pr.

[rleigh-codelibre]

Fails to build for me. Logs here. However, note that while the build "fails" there's nothing obvious in the logs--it appears to have built to completion; maybe something in the formula after that point?

[edit] Ah, found something buried halfway through:

./osx/osxbtcentralmanager_p.h:91:33: error: use of undeclared identifier 'CBService'; did you mean 'QBluetoothDeviceInfo::NoService'?
typedef QHash<QLowEnergyHandle, CBService *> ServiceHash;
                                ^~~~~~~~~
                                QBluetoothDeviceInfo::NoService
../../include/QtBluetooth/../../src/bluetooth/qbluetoothdeviceinfo.h:173:9: note: 'QBluetoothDeviceInfo::NoService' declared here
        NoService = 0x0000,
        ^
In file included from qlowenergyservice_osx.mm:35:
In file included from ./qlowenergycontroller_osx_p.h:49:
./osx/osxbtcentralmanager_p.h:91:44: error: expected expression
typedef QHash<QLowEnergyHandle, CBService *> ServiceHash;

./osx/osxbtcentralmanager_p.h:92:33: error: use of undeclared identifier 'CBCharacteristic'
typedef QHash<QLowEnergyHandle, CBCharacteristic *> CharHash;
                                ^
./osx/osxbtcentralmanager_p.h:92:51: error: expected expression
typedef QHash<QLowEnergyHandle, CBCharacteristic *> CharHash;
                                                  ^

./osx/osxbtcentralmanager_p.h:93:33: error: use of undeclared identifier 'CBDescriptor'
typedef QHash<QLowEnergyHandle, CBDescriptor *> DescHash;
                                ^
./osx/osxbtcentralmanager_p.h:93:47: error: expected expression
typedef QHash<QLowEnergyHandle, CBDescriptor *> DescHash;
                                              ^

./osx/osxbtcentralmanager_p.h:132:64: error: no type or protocol named 'CBCentralManagerDelegate'
@interface QT_MANGLE_NAMESPACE(OSXBTCentralManager) : NSObject<CBCentralManagerDelegate, CBPeripheralDelegate>
                                                               ^
./osx/osxbtcentralmanager_p.h:135:5: error: unknown type name 'CBCentralManager'; did you mean 'OSXBTCentralManager'?
    CBCentralManager *manager;
    ^~~~~~~~~~~~~~~~
    OSXBTCentralManager
./osx/osxbtcentralmanager_p.h:132:32: note: 'OSXBTCentralManager' declared here
@interface QT_MANGLE_NAMESPACE(OSXBTCentralManager) : NSObject<CBCentralManagerDelegate, CBPeripheralDelegate>
                               ^
./osx/osxbtcentralmanager_p.h:167:5: error: unknown type name 'CBPeripheral'
    CBPeripheral *peripheral;
    ^

[rleigh-codelibre]

Looks like this is #5391 (comment)

[ilovezfs]

@rleigh-codelibre already fixed that a while ago, if you re-pull :)

[DomT4]

I think getting rid of this would still be a mistake, FWIW.

[MikeMcQuaid]

@DomT4 Can you elaborate a bit more?

[DomT4]

I suspect it's still going to be very breaking, especially as Homebrew moves stuff from qt to qt5. The Qt ecosystem isn't exactly known for its rapid response to upstream changes. Up to y'all though, I'm no longer around really, just noticed this and thought I'd add the comment.

[ilovezfs]

@DomT4 thanks for chiming in. For the formulae mentioned in the comment, the situation currently is

• wireshark: upstream fixed it
• mkvtoolnix: upstream provides the configure option --without-qt-pkg-config and then checks the environment variables QT_CFLAGS and QT_LIBS
• poppler: upstream checks the environment variables POPPLER_QT5_CFLAGS, POPPLER_QT5_LIBS, POPPLER_QT5_TEST_CFLAGS, and POPPLER_QT5_TEST_LIBS as an alternative to pkg-config.

So if the patch is removed, these are the required diffs:

diff --git a/Formula/mkvtoolnix.rb b/Formula/mkvtoolnix.rb
index cd2e296..17ed39d 100644
--- a/Formula/mkvtoolnix.rb
+++ b/Formula/mkvtoolnix.rb
@@ -64,6 +64,10 @@ class Mkvtoolnix < Formula
     if build.with?("qt5")
       qt5 = Formula["qt5"]

+      ENV["QT_CFLAGS"] = "-I#{qt5.opt_include} -I#{qt5.opt_include}/QtNetwork -I#{qt5.opt_include}/QtWidgets -I#{qt5.opt_include}/QtGui -I#{qt5.opt_include}/QtCore"
+      ENV["QT_LIBS"] = "-F#{qt5.opt_lib} -framework QtNetwork -framework QtWidgets -framework QtGui -framework QtCore"
+
+      args << "--without-qt-pkg-config"
       args << "--with-moc=#{qt5.opt_bin}/moc"
       args << "--with-uic=#{qt5.opt_bin}/uic"
       args << "--with-rcc=#{qt5.opt_bin}/rcc"

diff --git a/Formula/poppler.rb b/Formula/poppler.rb
index a405768..f860c15 100644
--- a/Formula/poppler.rb
+++ b/Formula/poppler.rb
@@ -53,6 +53,13 @@ class Poppler < Formula
     ]

     if build.with? "qt5"
+      qt5 = Formula["qt5"]
+
+      ENV["POPPLER_QT5_CFLAGS"] = "-I#{qt5.opt_include} -I#{qt5.opt_include}/QtXml -I#{qt5.opt_include}/QtWidgets -I#{qt5.opt_include}/QtGui -I#{qt5.opt_include}/QtCore"
+      ENV["POPPLER_QT5_LIBS"] = "-F#{qt5.opt_lib} -framework QtXml -framework QtWidgets -framework QtGui -framework QtCore"
+      ENV["POPPLER_QT5_TEST_CFLAGS"] = "-I#{qt5.opt_include} -I#{qt5.opt_include}/QtTest -I#{qt5.opt_include}/QtCore"
+      ENV["POPPLER_QT5_TEST_LIBS"] = "-F#{qt5.opt_lib} -framework QtTest -framework QtCore"
+
       args << "--enable-poppler-qt5"
     else
       args << "--disable-poppler-qt5"

There are probably similar changes that would be needed in other taps too. If upstream is not going to reverse its decision to remove the pkg-config files, it seems at some point we need to bite the bullet and make the requisite changes (and do the corresponding upstream reporting) in formulae that are affected.

[MikeMcQuaid]

it seems at some point we need to bite the bullet and make the requisite changes (and do the corresponding upstream reporting) in formulae that are affected.

Agreed. We should stick to the upstream version wherever possible.

[ilovezfs]

poppler qt5 option fixed in #5864
mkvtoolnix qt5 option fixed in #5865

[rleigh-codelibre]

@ilovezfs Thanks. Tested again on 10.12 and it builds and links successfully, and my code builds and runs against it without problems.

[ilovezfs]

qca problem is fixed by a revision bump.

qjackctl problem is caused by opportunistic linking to portaudio during bottling and is fixed by adding the dependency or explicitly excluding it during configure.

Both are unrelated to this PR and can be fixed before, during, or after it without consequence.

[ilovezfs]

qca fixed by #5860
qjackctl fixed by #4836