Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbenv-gemset: disable #59058

Merged
merged 1 commit into from
Aug 3, 2020
Merged

rbenv-gemset: disable #59058

merged 1 commit into from
Aug 3, 2020

Conversation

Rylan12
Copy link
Member

@Rylan12 Rylan12 commented Aug 3, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

According to the README:

License

This code is placed in the public domain by the author, Jamis Buck. Use it as you wish. Please prefer good over evil.

While unlicensed, this doesn't use the Unlicense license.

The formula is being deleted because it does not have an OSI-approved license.

See #58225 (comment) and jf/rbenv-gemset#93

@BrewTestBot BrewTestBot added the bottle unneeded [DEPRECATED] Bottle does not need to be built label Aug 3, 2020
@chenrui333
Copy link
Member

Considering the unclearness of the license situation, I think we should actively disable or remove the formula.

@jonchang
Copy link
Contributor

jonchang commented Aug 3, 2020

@Rylan12
Copy link
Member Author

Rylan12 commented Aug 3, 2020

I went with removal as that's what was done for sflowtool (#58429) which was in the same situation.

Not sure if this should play into the decision at all but here is the analytics data from brew info:

==> Analytics
install: 333 (30 days), 1,091 (90 days), 4,910 (365 days)
install-on-request: 322 (30 days), 1,060 (90 days), 4,735 (365 days)
build-error: 0 (30 days)

@Rylan12 Rylan12 changed the title rbenv-gemset: remove license rbenv-gemset: delete formula Aug 3, 2020
@BrewTestBot BrewTestBot added the marked for removal/rejection PR is probably going to be closed or formula deleted label Aug 3, 2020
@SMillerDev
Copy link
Member

I'd like to disable this one. The difference is that sflowtool had a non-oss license and this has a license close, but not quite oss.

@jonchang
Copy link
Contributor

jonchang commented Aug 3, 2020

Do we support NOASSERTION in our license field? It's correct according to spec and I think it would cover the cases where we think a formula is compliant with our definition of what is acceptable in Homebrew/core but otherwise is not in the SPDX license list.

@Rylan12
Copy link
Member Author

Rylan12 commented Aug 3, 2020

I'd like to disable this one. The difference is that sflowtool had a non-oss license and this has a license close, but not quite oss.

Okay. I'll do that instead.

Do we support NOASSERTION in our license field?

I don't believe so. It might be something worth adding depending on how many formulae this would apply to.

Disable rbenv-gemset because it does not have an SPDX or OSI-approved
license.
@Rylan12 Rylan12 changed the title rbenv-gemset: delete formula rbenv-gemset: disable Aug 3, 2020
@Rylan12 Rylan12 added formula disabled Formula disabled and removed marked for removal/rejection PR is probably going to be closed or formula deleted labels Aug 3, 2020
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks! ❤️

@Rylan12 Rylan12 merged commit 2e05609 into Homebrew:master Aug 3, 2020
@Rylan12 Rylan12 deleted the rbenv-gemset-remove-license branch August 3, 2020 21:15
@Rylan12 Rylan12 mentioned this pull request Aug 3, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bottle unneeded [DEPRECATED] Bottle does not need to be built formula disabled Formula disabled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants