Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mesa: add license #59231

Merged
merged 1 commit into from
Aug 7, 2020
Merged

mesa: add license #59231

merged 1 commit into from
Aug 7, 2020

Conversation

chenrui333
Copy link
Member

add license for mesa project.

license doc ref, https://gitlab.freedesktop.org/mesa/mesa/-/blob/master/docs/license.rst

relates to #59220

@BrewTestBot BrewTestBot added the python Python use is a significant feature of the PR or issue label Aug 6, 2020
@Rylan12
Copy link
Member

Rylan12 commented Aug 6, 2020

I think we should hold off on the license based on the discussion in #58225 (comment)

@chenrui333
Copy link
Member Author

I think we should hold off on the license based on the discussion in #58225 (comment)

Yeah, I read about it (I understand lots of the formulae additions are not perfect).

But dealing with the license situation one by one can potentially mitigate the issue, either way, our goal is to reach to a place that we can have licenses for every formulae.

With that being said, I think this license addition is clear and good from my perspective.

@Rylan12
Copy link
Member

Rylan12 commented Aug 6, 2020

But dealing with the license situation one by one can potentially mitigate the issue, either way, our goal is to reach to a place that we can have licenses for every formulae.

I agree, but I think we just aren't ready to start that yet.

If you disagree, can you bring it up in #58225 so we can get the opinions of other maintainers who have been involved?

@SMillerDev
Copy link
Member

I don't think anyone suggested stopping all work on licenses. If we're sure about a license and it can be represented by the current implementation I don't see a reason to hold of.

@Rylan12
Copy link
Member

Rylan12 commented Aug 6, 2020

Okay, this sounds like it was a misunderstanding on my part of what was said. My apologies!

CI seems broken though...

@dtrodrigues dtrodrigues added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Aug 6, 2020
@dtrodrigues
Copy link
Member

I think it needs a rebase in order to trigger the CI-syntax-only logic that was just added.

@chenrui333
Copy link
Member Author

cancelled my PR build. I think the tap_syntax is fixed now?

@chenrui333
Copy link
Member Author

interesting that tests are all hanging:
image

@dtrodrigues
Copy link
Member

Those tests aren't hanging - they're yellow due to the branch protection checks. See #59208 (comment)

SMillerDev
SMillerDev previously approved these changes Aug 7, 2020
@BrewTestBot
Copy link
Member

:shipit: @SMillerDev has triggered a merge.

@BrewTestBot
Copy link
Member

⚠️ @SMillerDev bottle publish failed.

@BrewTestBot BrewTestBot dismissed SMillerDev’s stale review August 7, 2020 07:44

bottle publish failed

@dtrodrigues dtrodrigues merged commit 6527160 into Homebrew:master Aug 7, 2020
@chenrui333 chenrui333 deleted the mesa-license branch December 18, 2022 05:07
@chenrui333 chenrui333 added the license License PRs label Feb 6, 2024
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 11, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. license License PRs outdated PR was locked due to age python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants