Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitui 0.10.1 #60441

Closed
wants to merge 1 commit into from
Closed

gitui 0.10.1 #60441

wants to merge 1 commit into from

Conversation

extrawurst
Copy link
Contributor

@BrewTestBot BrewTestBot added the rust Rust use is a significant feature of the PR or issue label Aug 31, 2020
@dtrodrigues dtrodrigues mentioned this pull request Sep 1, 2020
Closed
@dtrodrigues
Copy link
Member

Still blocked by #60290 for now

@extrawurst
Copy link
Contributor Author

@dtrodrigues it should work now, right?

@dtrodrigues
Copy link
Member

Can you rebase on top of master which now includes Rust 1.46.0 and force-push please?

@dtrodrigues dtrodrigues force-pushed the update-gitui.rb-1598917764 branch from b7521d1 to 5cd16ec Compare September 1, 2020 13:03
@dtrodrigues
Copy link
Member

I was rebasing #60465 anyway for the rust upgrade so I did this one as well.

@dtrodrigues dtrodrigues force-pushed the update-gitui.rb-1598917764 branch from 5cd16ec to 44fcb54 Compare September 1, 2020 13:10
@extrawurst
Copy link
Contributor Author

what is this now?

==> FAILED
clang-format@8:
  * Versioned formulae in homebrew/core should use `keg_only :versioned_formula`
Error: 1 problem in 1 formula detected

@dtrodrigues
Copy link
Member

It got stuck in between a formula being merged and Homebrew/brew#8371 being merged, but now that it is, I've restarted the CI.

However, I did try and test this version of gitui locally and it failed, so the test may need to be adjusted.

@SMillerDev
Copy link
Member

@MikeMcQuaid you merged this one right?

@MikeMcQuaid
Copy link
Member

@SMillerDev Yes, it's fixed now.

@dtrodrigues
Copy link
Member

Looks like SHA: got changed to Sha: in this commit extrawurst/gitui@a95ffd7

@extrawurst
Copy link
Contributor Author

wow sorry for that, I did not even realize it when accepting the PR 🙈
changed the test script accordingly

@dtrodrigues dtrodrigues force-pushed the update-gitui.rb-1598917764 branch from c88918f to 1f8119d Compare September 1, 2020 14:05
dtrodrigues
dtrodrigues approved these changes Sep 1, 2020
View reviewed changes
Copy link
Member

@dtrodrigues dtrodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I squashed your commit which updated the test (which sounds like the change was unintentional, part of the reason we have tests). I've approved this PR now so it'll get merged as soon as CI passes again. Thanks work your patience while we worked through things, @extrawurst!

@dtrodrigues dtrodrigues self-requested a review September 1, 2020 14:43
@BrewTestBot
Copy link
Member

:shipit: @dtrodrigues has triggered a merge.

@extrawurst
Copy link
Contributor Author

@dtrodrigues I have to thank, keep up the great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtrodrigues dtrodrigues dtrodrigues approved these changes

Assignees
No one assigned
Labels
rust Rust use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@extrawurst @dtrodrigues @SMillerDev @MikeMcQuaid @BrewTestBot