Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc: depend on re2 #61214

Closed
wants to merge 4 commits into from
Closed

Conversation

SMillerDev
Copy link
Member

  • Have you followed the guidelines for contributing?
    -[x] Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Should fix #61151

@SMillerDev SMillerDev changed the title S miller dev patch 1 grpc: depend on re2 Sep 16, 2020
@bayandin
Copy link
Member

It looks like bloaty and dnsdist require a revision bump:

Error: 4 failed steps!
brew linkage --test bloaty
brew test --retry --verbose bloaty
brew linkage --test dnsdist
brew test --retry --verbose dnsdist

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@jonchang jonchang mentioned this pull request Sep 21, 2020
5 tasks
@fxcoudert
Copy link
Member

I think this is causing apache-arrow to fail building from source now with:

2020-10-10T19:57:41.2826500Z CMake Error at cmake_modules/Findre2.cmake:65 (add_library):
2020-10-10T19:57:41.2827150Z   add_library cannot create imported target "RE2::re2" because another target
2020-10-10T19:57:41.2827850Z   with the same name already exists.
2020-10-10T19:57:41.2828250Z Call Stack (most recent call first):
2020-10-10T19:57:41.2829030Z   /usr/local/lib/cmake/grpc/gRPCConfig.cmake:21 (find_package)
2020-10-10T19:57:41.2829760Z   cmake_modules/ThirdpartyToolchain.cmake:2453 (find_package)
2020-10-10T19:57:41.2830370Z   CMakeLists.txt:484 (include)

which is blocking #62560

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

conflict between grpc and re2
4 participants