Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxpython: add license + update homepage #62105

Merged
merged 2 commits into from
Oct 7, 2020
Merged

Conversation

urwrstkn8mare
Copy link
Contributor

@urwrstkn8mare urwrstkn8mare commented Oct 5, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Updated the homepage to what seemed more suitable (their official homepage) and added the license in the formula as well (2 different commits). (Inspiration: #58225)

See: https://wxpython.org/pages/license/

@BrewTestBot BrewTestBot added the python Python use is a significant feature of the PR or issue label Oct 5, 2020
@Rylan12 Rylan12 added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Oct 5, 2020
Rylan12
Rylan12 previously approved these changes Oct 5, 2020
Copy link
Member

@Rylan12 Rylan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @urwrstkn8mare!

This looks correct to me. The style issue seems to be a bug. I'm looking into it

@Rylan12
Copy link
Member

Rylan12 commented Oct 5, 2020

Okay, I've created a fix in Homebrew/brew#8862. Once that's merged this will be good to go!

@Rylan12
Copy link
Member

Rylan12 commented Oct 6, 2020

The fix has been merged, but you'll need to rebase your branch onto the latest master to fix the new issue.

@urwrstkn8mare
Copy link
Contributor Author

@Rylan12 do I need to fix the issue to merge? If so, is there any easy way to rebase my branch onto the latest master.

@Rylan12
Copy link
Member

Rylan12 commented Oct 7, 2020

The issue was unrelated to this PR, so this should be good to go once CI runs (I went ahead and rebased for you).

You can use the git rebase and git push --force commands to do this in the future (there's a brief explanation here)

@urwrstkn8mare
Copy link
Contributor Author

Thanks a lot for that. I'll make sure to have a look so in the future I'm able to do it myself. :)

@Rylan12 Rylan12 merged commit a92d9c1 into Homebrew:master Oct 7, 2020
@Rylan12
Copy link
Member

Rylan12 commented Oct 7, 2020

Thanks again, @urwrstkn8mare!

If you're curious, maybe check out https://www.atlassian.com/git/tutorials/rewriting-history/git-rebase for a more in-depth explanation of what a rebase is and how to do it

@chenrui333 chenrui333 added the license License PRs label Feb 6, 2024
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 11, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. license License PRs outdated PR was locked due to age python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants