-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wxpython: add license + update homepage #62105
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, @urwrstkn8mare!
This looks correct to me. The style issue seems to be a bug. I'm looking into it
Okay, I've created a fix in Homebrew/brew#8862. Once that's merged this will be good to go! |
The fix has been merged, but you'll need to rebase your branch onto the latest |
@Rylan12 do I need to fix the issue to merge? If so, is there any easy way to rebase my branch onto the latest |
The issue was unrelated to this PR, so this should be good to go once CI runs (I went ahead and rebased for you). You can use the |
Thanks a lot for that. I'll make sure to have a look so in the future I'm able to do it myself. :) |
Thanks again, @urwrstkn8mare! If you're curious, maybe check out https://www.atlassian.com/git/tutorials/rewriting-history/git-rebase for a more in-depth explanation of what a rebase is and how to do it |
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install <formula>
)?Updated the homepage to what seemed more suitable (their official homepage) and added the license in the formula as well (2 different commits). (Inspiration: #58225)
See: https://wxpython.org/pages/license/